Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting: JNI module for Java/Android wrappers #420

Merged
merged 6 commits into from
Mar 11, 2019
Merged

Formatting: JNI module for Java/Android wrappers #420

merged 6 commits into from
Mar 11, 2019

Commits on Mar 7, 2019

  1. Formatting: JNI module for Java/Android wrappers 

    Add JNI to the formatting target. It is a bit special because we have to
specify path to JVM's headers.
    @ilammy
    ilammy committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    5709c4f View commit details
    Browse the repository at this point in the history

  2. Style changes suggested by clang-tidy 

    - Avoid returning from both "then" and "else" branches
- Initialize possibly uninitialized variables
    @ilammy
    ilammy committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    262f0f9 View commit details
    Browse the repository at this point in the history

  3. Avoid "private" and "public" identifiers 

    clang-format treats them as C++ keywords when formatting code which
results in dumb formatting so don't use these words.
    @ilammy
    ilammy committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    4cca35c View commit details
    Browse the repository at this point in the history

  4. Reformat the code

    @forelocked-beobachter @ilammy
    forelocked-beobachter authored and ilammy committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    6abffdf View commit details
    Browse the repository at this point in the history

  5. Install JDK for formatting 

    Keep it in CircleCI configuration for now, we'll move it into Docker
image later.
    @ilammy
    ilammy committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    aa2aed3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into format-jni

    @ilammy
    ilammy committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    b5dcfd3 View commit details
    Browse the repository at this point in the history