Formatting: JNI module for Java/Android wrappers #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add JNI to the formatting target. It is a bit special because we have to specify path to JVM's headers.
- Avoid returning from both "then" and "else" branches - Initialize possibly uninitialized variables
clang-format treats them as C++ keywords when formatting code which results in dumb formatting so don't use these words.
Keep it in CircleCI configuration for now, we'll move it into Docker image later.
forelocked-beobachter
added
O-Android 🤖
vixentael
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JNI to the formatting target. It is a bit special because we have to specify path to JDK headers (and actually install JDK for that).
clang-tidy suggested some changes, they are applied as a separate commit for review:
Also, it turned out that clang-format treats
privateandpublicas C++ keywords when formatting C code which results in dumb formatting. Rename identifiers intoprivate_keyto avoid this.