Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile for 4.3.x #3057

Merged
merged 3 commits into from
Jan 25, 2023
Merged

Update Dockerfile for 4.3.x #3057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccb7583
chore: adding dockerfile for 4.3.x
chatton Jan 25, 2023
49e2f75
chore: updating comment in Dockerfile
chatton Jan 25, 2023
b776a1a
chore: add build argument when building the release image
chatton Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,5 @@ jobs:
context: .
push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
build-args: |
IBC_GO_VERSION="${{ github.ref_name }}"
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Docker Build
run: docker build . --no-cache
run: docker build . --no-cache --build-arg IBC_GO_VERSION=v4.3.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the final version doesn't really matter here, this test just ensures the docker build succeeds. This image isn't used for anything.


split-test-files:
runs-on: ubuntu-latest
Expand Down
17 changes: 13 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,32 @@
FROM golang:1.18 as builder
FROM golang:1.19 as builder

ARG IBC_GO_VERSION

ENV GOPATH=""
ENV GOMODULE="on"

# ensure the ibc go version is being specified for this image.
RUN test -n "${IBC_GO_VERSION}"

COPY go.mod .
COPY go.sum .

RUN go mod download

ADD testing testing
ADD modules modules
ADD LICENSE LICENSE
COPY testing testing
COPY modules modules
COPY LICENSE LICENSE

COPY Makefile .

RUN make build

FROM ubuntu:20.04

ARG IBC_GO_VERSION

LABEL "org.cosmos.ibc-go" "${IBC_GO_VERSION}"

COPY --from=builder /go/build/simd /bin/simd

ENTRYPOINT ["simd"]