Update Dockerfile for 4.3.x #3057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
damiannolan
as code owners
chatton
commented
Jan 25, 2023
| @@ -56,7 +56,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - name: Docker Build | |||
| run: docker build . --no-cache | |||
| run: docker build . --no-cache --build-arg IBC_GO_VERSION=v4.3.0 | |||
There was a problem hiding this comment.
the final version doesn't really matter here, this test just ensures the docker build succeeds. This image isn't used for anything.
damiannolan
approved these changes
Jan 25, 2023
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 27, 2023
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
ulbqb
pushed a commit
to ulbqb/ibc-go
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Dockerfile for 4.3.x to include a build argument which will be used to specify the ibc-go version.
If this PR is approved and everything works correctly, we can apply these changes to all of our release branches.
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.