-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the Unauthorized error of full node caused by mempool tx #8511
fix the Unauthorized error of full node caused by mempool tx #8511
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@@ -196,10 +196,6 @@ func OnlyLegacyAminoSigners(sigData signing.SignatureData) bool { | |||
} | |||
|
|||
func (svd SigVerificationDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, next sdk.AnteHandler) (newCtx sdk.Context, err error) { | |||
// no need to verify signatures on recheck tx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not correct. We can and should bypass signature verification on rechecking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking until we get consensus on the correct behavior. @alexanderbez ?
The The |
It was reverted in #6291. Do you have any context for that @alexanderbez ? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
It was to allow multiple txs in the same block from a sender which has always been a point of confusion for me. |
pinging for an update here |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
closes: #8510
NewIncrementSequenceDecorator
when the old tx was rechecked. So,theNewIncrementSequenceDecorator
function should be skipped in recheck.NewIncrementSequenceDecorator
andNewSigVerificationDecorator
were skipped in recheck, the old tx would always exist in the memory pool. And ifNewSigVerificationDecorator
is not be skipped in recheck, the old tx would fail to verify signature and be removed when the sequence of user was updated.So the
NewIncrementSequenceDecorator
function should be skipped in recheck but notNewSigVerificationDecorator
.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes