fix #6287 sending multiple transactions from an account make nonce sequence stuck #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce sequence stuck
ahmedaly113
requested review from
aaronc,
alessio,
alexanderbez,
clevinson,
fedekunze and
jgimeno
as code owners
alexanderbez
suggested changes
May 27, 2020
There was a problem hiding this comment.
Thanks @ahmedaly113. Can we add unit tests to ante pkg? Also integration test in baseapp. Finally, a changelog entry stating a bug fix 👍
Codecov Report
@@ Coverage Diff @@
## master #6291 +/- ##
==========================================
- Coverage 55.66% 55.66% -0.01%
==========================================
Files 447 447
Lines 26881 26879 -2
==========================================
- Hits 14964 14962 -2
Misses 10850 10850
Partials 1067 1067 |
alessio
reviewed
May 28, 2020
alessio
approved these changes
May 28, 2020
|
I'd wait for @AdityaSripal's review before merging |
AdityaSripal
approved these changes
May 28, 2020
alexanderbez
added
the
A:automerge
4 tasks
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix nonce stuck issue when sending multiple transactions from an account in a same block. Issue behavior is "unauthorized: signature verification failed" for correctly signed transaction. Detailed discussions are available on closing issue.
closes: #6287