Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: ensure b.ReportAllocs() in all the benchmarks #8460

Merged
merged 2 commits into from
Jan 28, 2021

Conversation

odeke-em
Copy link
Collaborator

With this change, we'll get details on the number of
allocations performed by code. Later on when we have
continuous benchmarking infrastructure, this change
will prove useful to flag regressions.

Fixes #8459


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

With this change, we'll get details on the number of
allocations performed by code. Later on when we have
continuous benchmarking infrastructure, this change
will prove useful to flag regressions.

Fixes #8459
@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #8460 (c64b6af) into master (580e968) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8460      +/-   ##
==========================================
- Coverage   61.48%   61.47%   -0.01%     
==========================================
  Files         630      630              
  Lines       36398    36398              
==========================================
- Hits        22379    22377       -2     
- Misses      11670    11671       +1     
- Partials     2349     2350       +1     
Impacted Files Coverage Δ
snapshots/store.go 74.31% <0.00%> (-1.10%) ⬇️

@odeke-em odeke-em merged commit 784a9a6 into master Jan 28, 2021
@odeke-em odeke-em deleted the tests-add-b.ReportAllocs-in-all-benchmarks branch January 28, 2021 07:52
@odeke-em
Copy link
Collaborator Author

Thanks for the review and approval @alessio!

larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
With this change, we'll get details on the number of
allocations performed by code. Later on when we have
continuous benchmarking infrastructure, this change
will prove useful to flag regressions.

Fixes cosmos#8459

Co-authored-by: Alessio Treglia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all: add (*testing.B).ReportAllocs() to all the benchmarks to ensure allocations are reported
2 participants