Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: add (*testing.B).ReportAllocs() to all the benchmarks to ensure allocations are reported #8459

Closed
4 tasks done
odeke-em opened this issue Jan 27, 2021 · 0 comments · Fixed by #8460
Closed
4 tasks done

all: add (*testing.B).ReportAllocs() to all the benchmarks to ensure allocations are reported #8459

odeke-em opened this issue Jan 27, 2021 · 0 comments · Fixed by #8460
Assignees
@odeke-em
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@odeke-em
Copy link
Collaborator

To aid in the upcoming infrastructure for benchmarking SDK changes on various commits, it is useful to know the emitted allocations, to measure improvements.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@odeke-em odeke-em added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jan 27, 2021
@odeke-em odeke-em self-assigned this Jan 27, 2021
odeke-em added a commit that referenced this issue Jan 27, 2021
@odeke-em
all: ensure b.ReportAllocs() in all the benchmarks
ee2085e 
With this change, we'll get details on the number of
allocations performed by code. Later on when we have
continuous benchmarking infrastructure, this change
will prove useful to flag regressions.

Fixes #8459
@odeke-em odeke-em mentioned this issue Jan 27, 2021
Merged
9 tasks
odeke-em added a commit that referenced this issue Jan 28, 2021
@odeke-em
all: ensure b.ReportAllocs() in all the benchmarks (#8460)
784a9a6 
With this change, we'll get details on the number of
allocations performed by code. Later on when we have
continuous benchmarking infrastructure, this change
will prove useful to flag regressions.

Fixes #8459

Co-authored-by: Alessio Treglia <[email protected]>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this issue May 22, 2023
@odeke-em
all: ensure b.ReportAllocs() in all the benchmarks (cosmos#8460)
a96e761 
With this change, we'll get details on the number of
allocations performed by code. Later on when we have
continuous benchmarking infrastructure, this change
will prove useful to flag regressions.

Fixes cosmos#8459

Co-authored-by: Alessio Treglia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odeke-em odeke-em

Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

all: ensure b.ReportAllocs() in all the benchmarks cosmos/cosmos-sdk
1 participant
@odeke-em