Fix add-genesis-account in simd #7069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7069 +/- ##
==========================================
+ Coverage 54.66% 54.78% +0.11%
==========================================
Files 541 541
Lines 36887 36887
==========================================
+ Hits 20165 20208 +43
+ Misses 15077 15023 -54
- Partials 1645 1656 +11 |
amaury1093
reviewed
Aug 17, 2020
simapp/simd/cmd/genaccounts.go
Outdated
| @@ -140,7 +141,7 @@ contain valid denominations. Accounts may optionally be supplied with vesting pa | |||
| } | |||
| authGenState.Accounts = genAccs | |||
|
|
|||
| authGenStateBz, err := cdc.MarshalJSON(authGenState) | |||
| authGenStateBz, err := json.MarshalIndent(authGenState, "", "") | |||
There was a problem hiding this comment.
should we add a test for this command?
In #7037, I added a test in simapp/simd/cmd/cmd_test.go. But maybe they are not perfect there (ref: #7037 (comment)). Were do you think they should go @alexanderbez?
There was a problem hiding this comment.
Ideally, they're tested where they're defined. We can test this command in this package as you've done.
9 tasks
|
Thanks for the fix @sahith-narahari , waiting for the test so we don't break the simd that much :D |
sahith-narahari
requested review from
aaronc,
alessio,
clevinson,
fedekunze and
jgimeno
as code owners
alessio
approved these changes
Aug 17, 2020
fedekunze
approved these changes
Aug 17, 2020
sahith-narahari
added
the
A:automerge
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* Update genaccounts to use encoding/json * Fix add genesis accounts * Add test for genaccounts * Code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #7037
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes