-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cli test for query Account #6973
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6973 +/- ##
==========================================
+ Coverage 54.70% 54.73% +0.02%
==========================================
Files 539 540 +1
Lines 36802 36812 +10
==========================================
+ Hits 20134 20149 +15
+ Misses 15026 15021 -5
Partials 1642 1642 |
@atheeshp let me know which modules you're tackling, to ensure there's no collision |
Okay, @sahith-narahari |
…sahith/add-query-clitests
…sdk into sahith/add-query-clitests
…hith/add-query-clitests
I think this is R4R now @sahith-narahari. Can you just take a quick look through the diff and checks? I won't be able to look till later |
Sure @aaronc, I'll take it from here |
…ts' into sahith/add-query-clitests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK! Although, I'd prefer to not merge this until we can get a local network running so we can play with these commands in a live manner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending tests pass
@alessio localnet still doesn't work and I wanted to test this before merging. |
Alright, @alexanderbez I can revert it if you think it'd better so |
@alexanderbez actually @sahith-narahari is working on a fix here: #7069 |
Description
Fixes #7007
This PR adds missing test for query account and refactor some tests. I see there're some tests missing for staking, gov module, which I'll add in a separate PR.
Ref: #6571
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes