Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate account getters from client/context #4579

Merged
merged 6 commits into from
Jun 19, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 18, 2019

Closes: #4543

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #4579 into master will increase coverage by 0.04%.
The diff coverage is 41.17%.

@@            Coverage Diff             @@
##           master    #4579      +/-   ##
==========================================
+ Coverage   52.61%   52.66%   +0.04%     
==========================================
  Files         263      264       +1     
  Lines       16464    16483      +19     
==========================================
+ Hits         8662     8680      +18     
  Misses       7154     7154              
- Partials      648      649       +1

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but I don't like the extra wrapper on the NodeQuerier interface

tests/mocks/account_retriever.go Show resolved Hide resolved
tests/mocks/account_retriever.go Show resolved Hide resolved
x/auth/client/cli/tx_multisign.go Show resolved Hide resolved
x/auth/types/account_retriever.go Show resolved Hide resolved
@sabau
Copy link
Contributor

sabau commented Jun 19, 2019

Can we add a make command and [or] some doc on how to manage/update/create mocks using mockgen, or just the example of how you achieved it here

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alessio alessio dismissed fedekunze’s stale review June 19, 2019 12:22

Fede and I talked through the changes. Hence dismissing the review.

@alessio alessio merged commit 1eb7706 into master Jun 19, 2019
@alessio alessio deleted the alessio/refactor-account-getter branch June 19, 2019 12:24
@JimLarson
Copy link
Contributor

Please disregard the previous unrelated PR - was supposed to be an issue in a different repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove account getters in CLIContext
5 participants