Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement staked-prefers-unvested policy #182

Merged
merged 6 commits into from
Mar 1, 2022
Merged

Conversation

JimLarson
Copy link

@JimLarson JimLarson commented Mar 1, 2022

Description

Closes: Agoric/agoric-sdk#4579

Updates the behavior of PeriodicVestingAccount and ClawbackVestingAccount when receiving a new grant (or intercepted rewards in clawback accounts) to consistently interpret staked tokens as unvested first. Upon new grants, adjusts bookkeeping to recognize historical slashing to avoid premature access to tokens which should be locked. (See Agoric/agoric-sdk#4300)

Author Checklist

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@JimLarson JimLarson added bug Something isn't working C:x/auth agoric-cosmos Agoric tags for cosmos labels Mar 1, 2022
@JimLarson JimLarson self-assigned this Mar 1, 2022
Copy link
Collaborator

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Makes sense.

@JimLarson JimLarson added the automerge Merge PR with Mergify.io label Mar 1, 2022
@mergify mergify bot merged commit 2d12da2 into Agoric Mar 1, 2022
@mergify mergify bot deleted the 4579-staking-unvested branch March 1, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos Agoric tags for cosmos automerge Merge PR with Mergify.io bug Something isn't working C:x/auth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update vesting accounts for staking-prefers-unvested strategy
2 participants