Return correct error on invalid messages #4100
Merged
+127
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
WIP
T: API Breaking
alexanderbez
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #4100 +/- ##
==========================================
+ Coverage 59.97% 60.1% +0.12%
==========================================
Files 211 211
Lines 15111 15114 +3
==========================================
+ Hits 9063 9084 +21
+ Misses 5428 5410 -18
Partials 620 620 |
alexanderbez
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
alexanderbez
changed the title
alessio
suggested changes
Apr 15, 2019
|
Added test cases for this exact path @alessio |
fedekunze
reviewed
Apr 15, 2019
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestInvalidMsg(t *testing.T) { |
There was a problem hiding this comment.
wow, we didn't have any test for the handler ?
There was a problem hiding this comment.
Not directly, no. I believe most of the handler testing is done through simulation and app/abci module tests, but not directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #3978
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
sdkch add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: