Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module handler decode error #3978

Closed
rigelrozanski opened this issue Mar 26, 2019 · 0 comments · Fixed by #4100
Closed

module handler decode error #3978

rigelrozanski opened this issue Mar 26, 2019 · 0 comments · Fixed by #4100
Assignees
@alexanderbez
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Milestone
v0.36.0

Comments

@rigelrozanski
Copy link
Contributor

rigelrozanski commented Mar 26, 2019 •
edited by alexanderbez
Loading

Throughout the module handlers, unknown message types are returned with the error ErrTxDecode which is not necessarily correct, quoting @alexanderbez "somehow a message got routed incorrectly or the type is unsupported. It has nothing to do with tx decoding (at least not directly)."

Acceptance Criteria

  • Messages that are routed improperly should return an ErrUnknownRequest error
@rigelrozanski rigelrozanski added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Mar 26, 2019
@rigelrozanski rigelrozanski mentioned this issue Mar 26, 2019
Merged
5 tasks
@rigelrozanski rigelrozanski added this to the v0.35.0 milestone Apr 8, 2019
@alexanderbez alexanderbez self-assigned this Apr 11, 2019
@alexanderbez alexanderbez mentioned this issue Apr 11, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
v0.36.0
Development

Successfully merging a pull request may close this issue.

Return correct error on invalid messages cosmos/cosmos-sdk
2 participants
@alexanderbez @rigelrozanski