fix: multiple typos #25120
fix: multiple typos #25120
Conversation
📝 WalkthroughWalkthroughThis update consists entirely of documentation and comment corrections across multiple files. Changes include fixing typos, clarifying comments, correcting references to RFCs, PR numbers, and service names, as well as improving HTML structure in documentation. No functional, behavioral, or API surface changes are present in the codebase. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
x/tx/signing/textual/bytes.go (1)
59-61: Be robust to all whitespace, not just spaces, during hex parseUsers may paste inputs with tabs/newlines. Consider stripping all whitespace before decoding.
Apply within this range:
-// Remove all spaces from the string before hex decoding -data, err := hex.DecodeString(strings.ReplaceAll(formatted, " ", "")) +// Remove all whitespace characters before hex decoding +cleaned := strings.Join(strings.Fields(formatted), "") +data, err := hex.DecodeString(cleaned)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting
📒 Files selected for processing (12)
CHANGELOG.md(2 hunks)README.md(1 hunks)x/tx/signing/textual/bench_test.go(0 hunks)x/tx/signing/textual/bool.go(1 hunks)x/tx/signing/textual/bytes.go(2 hunks)x/tx/signing/textual/coin_test.go(1 hunks)x/tx/signing/textual/internal/cbor/cbor.go(1 hunks)x/upgrade/README.md(3 hunks)x/upgrade/module.go(1 hunks)x/upgrade/plan/downloader.go(1 hunks)x/upgrade/plan/info.go(1 hunks)x/upgrade/types/errors.go(1 hunks)
💤 Files with no reviewable changes (1)
- x/tx/signing/textual/bench_test.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Summary
🔇 Additional comments (14)
x/tx/signing/textual/internal/cbor/cbor.go (1)
2-2: Fix correct RFC reference (8949) — good catch. The package comment now points to the right CBOR RFC. No behavioral changes.x/upgrade/types/errors.go (1)
7-7: Module name in comment corrected. Header now accurately references x/upgrade; aligns with the file’s contents.x/tx/signing/textual/coin_test.go (1)
119-119: Comment matches struct name. The identifier in the comment now correctly reflects coinJSONTest.x/upgrade/plan/downloader.go (1)
26-26: Docstring typo fixed. “This function does not check the provided url for validity.” reads correctly now.README.md (1)
27-30: Badge anchors correctly closed and separated. The Sims link is properly closed before opening the Lint badge anchor; HTML structure is now valid.x/tx/signing/textual/bool.go (1)
13-13: Comment now matches actual rendering behavior ("True"/"False")Accurate and aligned with Format/Parse. Nice cleanup.
x/upgrade/module.go (1)
160-160: Clarified PreBlock contract wording“Before other modules’ PreBlock” is correct. Thanks for tightening this.
x/upgrade/README.md (3)
73-77: Lifecycle hook corrected to PreBlockThis matches the module comment and current behavior.
507-507: gRPC service path fix for CurrentPlanCommand now targets cosmos.upgrade.v1beta1.Query/CurrentPlan. Looks good.
529-529: gRPC service path fix for ModuleVersionsCommand now targets cosmos.upgrade.v1beta1.Query/ModuleVersions. LGTM.
x/upgrade/plan/info.go (1)
44-44: Grammar fix (“a GET request”)Good editorial correction; no behavioral impact.
x/tx/signing/textual/bytes.go (1)
68-68: Comment clarified (“after every 4th character”)Matches actual formatting logic. Good.
CHANGELOG.md (2)
55-55: LGTM: Correct PR reference for abci_utils (#25008).The link and message look accurate and consistent with surrounding entries.
87-87: LGTM: Spacing after the (perf) tag normalized.Improves consistency with the rest of the changelog entries.
|
Hi @aljo242 ! |
2 participants
Description
CHANGELOG.md
[#25008](https://github.com/cosmos/cosmos-sdk/pull/ 24861)
#25008](https://github.com/cosmos/cosmos-sdk/pull/ 25008) - correct link
[#24551](https://github.com/cosmos/cosmos-sdk/pull/ 24551) -- deleted duplicate
(perf)[#24045] - add missing space
x/tx/signing/textual/bench_test.go
protoreflect.ValueOfString("77777777777777777777777777777777700") -- deleted duplicate
Summary by CodeRabbit