feat: set signer extraction adapter #25008

vladjdk · 2025-07-25T15:48:00Z

Adds a setter for signer extraction adapter.

Summary by CodeRabbit

New Features
- Added the ability to assign a custom signer extraction adapter within proposal handling.

coderabbitai · 2025-07-25T15:50:12Z

📝 Walkthrough

Walkthrough

A setter method named SetSignerExtractionAdapter was added to the DefaultProposalHandler struct in baseapp/abci_utils.go. This method enables external assignment of a custom SignerExtractionAdapter to the handler. No other logic or control flow was modified.

Changes

File(s)	Change Summary
baseapp/abci_utils.go	Added `SetSignerExtractionAdapter` method to `DefaultProposalHandler` struct.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch vlad/signer-extraction-adapter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

baseapp/abci_utils.go (1)
233-236: Docstring clarity & nil-adapter safeguard

The comment currently says: “sets the SetSignerExtractionAdapter”, which is redundant and unclear.

More importantly, callers can pass nil. PrepareProposalHandler later dereferences h.signerExtAdapter (line 301) without a nil check, so a nil assignment here will trigger a runtime panic under load.
-// SetSignerExtractionAdapter sets the SetSignerExtractionAdapter on the DefaultProposalHandler.
+// SetSignerExtractionAdapter replaces the signer extraction adapter used by
+// DefaultProposalHandler. The adapter must be non-nil.
 func (h *DefaultProposalHandler) SetSignerExtractionAdapter(signerExtAdapter mempool.SignerExtractionAdapter) {
-	h.signerExtAdapter = signerExtAdapter
+	if signerExtAdapter == nil {
+		panic("SetSignerExtractionAdapter: adapter must not be nil")
+	}
+	h.signerExtAdapter = signerExtAdapter
 }
This keeps behaviour consistent with PrepareProposalHandler while preventing hard-to-trace panics.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 6434818 and 3f8ef36.

📒 Files selected for processing (1)

baseapp/abci_utils.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)

GitHub Check: test-system
GitHub Check: test-system-legacy
GitHub Check: tests (02)
GitHub Check: tests (01)
GitHub Check: tests (00)
GitHub Check: tests (03)
GitHub Check: test-cosmovisor
GitHub Check: test-integration
GitHub Check: test-sim-nondeterminism
GitHub Check: test-e2e
GitHub Check: test-math
GitHub Check: test-store
GitHub Check: Analyze
GitHub Check: Check up to date mocks
GitHub Check: build (arm64)
GitHub Check: build (amd64)
GitHub Check: dependency-review
GitHub Check: Gosec
GitHub Check: golangci-lint
GitHub Check: Summary

mmsqe · 2025-07-25T15:54:08Z

baseapp/abci_utils.go


+// SetSignerExtractionAdapter sets the SetSignerExtractionAdapter on the DefaultProposalHandler.
+func (h *DefaultProposalHandler) SetSignerExtractionAdapter(signerExtAdapter mempool.SignerExtractionAdapter) {
+	h.signerExtAdapter = signerExtAdapter


we use like this actually

How are you getting transactions to pass through here?

cosmos-sdk/baseapp/abci_utils.go

Lines 301 to 306 in 3f8ef36

signerData, err := h.signerExtAdapter.GetSigners(memTx)

if err != nil {

// propagate the error to the caller

resError = err

return false

}

aljo242

lgtm with changelog - added backport flag

Co-authored-by: Alex | Interchain Labs <[email protected]> (cherry picked from commit da4517a) # Conflicts: # CHANGELOG.md

Co-authored-by: Vlad J <[email protected]> Co-authored-by: aljo242 <[email protected]>

Co-authored-by: Alex | Interchain Labs <[email protected]>

set signer extraction adapter

3f8ef36

github-project-automation bot added this to Interchain Public Works Jul 25, 2025

This comment has been minimized.

Sign in to view

coderabbitai bot reviewed Jul 25, 2025

View reviewed changes

mmsqe reviewed Jul 25, 2025

View reviewed changes

aljo242 added the backport/v0.53.x label Jul 25, 2025

aljo242 changed the title ~~set signer extraction adapter~~ feat: set signer extraction adapter Jul 25, 2025

Merge branch 'main' into vlad/signer-extraction-adapter

e5a0c83

aljo242 approved these changes Jul 25, 2025

View reviewed changes

add changelog

cc2f6b0

aljo242 added this pull request to the merge queue Jul 25, 2025

Merged via the queue into main with commit da4517a Jul 25, 2025
41 checks passed

aljo242 deleted the vlad/signer-extraction-adapter branch July 25, 2025 17:54

github-project-automation bot moved this to 🥳 Done in Interchain Public Works Jul 25, 2025

mergify bot pushed a commit that referenced this pull request Jul 25, 2025

feat: set signer extraction adapter (#25008)

e25a3b9

Co-authored-by: Alex | Interchain Labs <[email protected]> (cherry picked from commit da4517a) # Conflicts: # CHANGELOG.md

mergify bot mentioned this pull request Jul 25, 2025

feat: set signer extraction adapter (backport #25008) #25012

Merged

aljo242 pushed a commit that referenced this pull request Jul 25, 2025

feat: set signer extraction adapter (backport #25008) (#25012)

908df9d

Co-authored-by: Vlad J <[email protected]> Co-authored-by: aljo242 <[email protected]>

skosito mentioned this pull request Jul 28, 2025

refactor: cleanup mempool fork zeta-chain/node#4060

Merged

5 tasks

sewqasreedas mentioned this pull request Aug 8, 2025

fix: multiple typos #25120

Closed

yihuang pushed a commit to yihuang/cosmos-sdk that referenced this pull request Aug 11, 2025

feat: set signer extraction adapter (cosmos#25008)

0399fa7

Co-authored-by: Alex | Interchain Labs <[email protected]>

yihuang pushed a commit to yihuang/cosmos-sdk that referenced this pull request Aug 13, 2025

feat: set signer extraction adapter (cosmos#25008)

ab85abe

Co-authored-by: Alex | Interchain Labs <[email protected]>

yihuang pushed a commit to MANTRA-Chain/cosmos-sdk that referenced this pull request Aug 13, 2025

feat: set signer extraction adapter (cosmos#25008)

2660a4c

Co-authored-by: Alex | Interchain Labs <[email protected]>

letmehateu mentioned this pull request Aug 23, 2025

fix(typos): correct HTML code and link to PR #25246

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: set signer extraction adapter #25008

feat: set signer extraction adapter #25008

Uh oh!

vladjdk commented Jul 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

This comment has been minimized.

coderabbitai bot commented Jul 25, 2025

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

mmsqe Jul 25, 2025

Uh oh!

vladjdk Jul 25, 2025

Uh oh!

aljo242 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	signerData, err := h.signerExtAdapter.GetSigners(memTx)
	if err != nil {
	// propagate the error to the caller
	resError = err
	return false
	}

feat: set signer extraction adapter #25008

feat: set signer extraction adapter #25008

Uh oh!

Conversation

vladjdk commented Jul 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

This comment has been minimized.

coderabbitai bot commented Jul 25, 2025

Walkthrough

Changes

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

mmsqe Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

vladjdk Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

aljo242 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vladjdk commented Jul 25, 2025 •

edited by coderabbitai bot

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)