R4R: Simplify version handling, rely on git describe

[alessio]

Simplify version handling, rely on git describe

Closes: #1941

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
• Wrote tests
• Updated relevant documentation (docs/)
• Added entries in PENDING.md with issue #
• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[cwgoes]

I think this is an excellent idea but cc @greg-szabo are we still parsing version/version.go manually?

[greg-szabo]

We do, but we don't build automated gaiad builds anymore. When we decide to do it again, we'll have to rewrite/fix the automation. Feel free to go ahead with this change.

Historically (I mean in the Tendermint repo) we only tagged the code when a new release was cut. I guess with moving the version information into tags, you want to change that process? (I couldn't make the team immediately update the version number on develop when a new release was deployed.)

In Tendermint, the automated release also creates a tag on master, I wonder if that becomes available in develop too.

[alessio]

@greg-szabo dixit:

I guess with moving the version information into tags, you want to change that process?

No, we don't want to. This is all about providing develop builds with numeric versioning schema

[greg-szabo]

The change I'm thinking of is that when you deploy a release to master, you have to add a new tag to develop at least... (So the master deployments version number is the tag that was created on develop during the previous release - or something newer than that).

[codecov]

Codecov Report

Merging #2318 into develop will decrease coverage by 1.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2318      +/-   ##
==========================================
- Coverage    64.97%   63.9%   -1.08%     
==========================================
  Files          135     140       +5     
  Lines         8418    8714     +296     
==========================================
+ Hits          5470    5569      +99     
- Misses        2587    2766     +179     
- Partials       361     379      +18

[cwgoes]

Odd CI failures, possibly unrelated to this PR?

[cwgoes]

Tested ACK