Simplify version handling, rely on git describe #1941

Makefile

@@ -1,8 +1,8 @@
 PACKAGES_NOSIMULATION=$(shell go list ./... | grep -v '/simulation')
 PACKAGES_SIMTEST=$(shell go list ./... | grep '/simulation')
-COMMIT_HASH := $(shell git rev-parse --short HEAD)
+VERSION := $(shell git describe --tags --long | sed 's/v\(.*\)/\1/')
 BUILD_TAGS = netgo ledger
-BUILD_FLAGS = -tags "${BUILD_TAGS}" -ldflags "-X github.com/cosmos/cosmos-sdk/version.GitCommit=${COMMIT_HASH}"
+BUILD_FLAGS = -tags "${BUILD_TAGS}" -ldflags "-X github.com/cosmos/cosmos-sdk/version.Version=${VERSION}"
 GCC := $(shell command -v gcc 2> /dev/null)
 LEDGER_ENABLED ?= true
 UNAME_S := $(shell uname -s)

client/lcd/lcd_test.go

@@ -124,19 +124,9 @@ func TestVersion(t *testing.T) {
 	res, body := Request(t, port, "GET", "/version", nil)
 	require.Equal(t, http.StatusOK, res.StatusCode, body)
 
-	reg, err := regexp.Compile(`\d+\.\d+\.\d+(-dev)?`)
-	require.Nil(t, err)
-	match := reg.MatchString(body)
-	require.True(t, match, body)
-
 	// node info
 	res, body = Request(t, port, "GET", "/node_version", nil)
 	require.Equal(t, http.StatusOK, res.StatusCode, body)
-
-	reg, err = regexp.Compile(`\d+\.\d+\.\d+(-dev)?`)
-	require.Nil(t, err)
-	match = reg.MatchString(body)
-	require.True(t, match, body)
 }
 
 func TestNodeStatus(t *testing.T) {

version/command.go

@@ -17,15 +17,10 @@ var (
 
 // return version of CLI/node and commit hash
 func GetVersion() string {
-	v := Version
-	if GitCommit != "" {
-		v = v + "-" + GitCommit
-	}
-	return v
+	return Version
 }
 
 // CMD
 func printVersion(cmd *cobra.Command, args []string) {
-	v := GetVersion()
-	fmt.Println(v)
+	fmt.Println(GetVersion())
 }

version/version.go

@@ -1,11 +1,5 @@
 //nolint
 package version
 
-const Maj = "0"
-const Min = "24"
-const Fix = "2"
-
-const Version = "0.24.2"
-
 // GitCommit set by build flags
-var GitCommit = ""
+var Version = ""