Eichain/v0.46.16 #21333
Eichain/v0.46.16 #21333
Conversation
(cherry picked from commit 5905dd7) Co-authored-by: Aleksandr Bezobchuk <[email protected]>
) (cosmos#12123) ## Description Closes: cosmos#12040 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit f71d464) Co-authored-by: Marie Gauthier <[email protected]>
(cherry picked from commit 67a04a5) Co-authored-by: Amaury <[email protected]>
…mos#12136) ## Description It seems like we added `--fee-payer` and `--fee-granter` flags to the CLI, but when generating a tx, they are ignored. ref: cosmos#11880 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 889dfcb) Co-authored-by: Amaury <[email protected]>
…5.6 (backport cosmos#12146) (cosmos#12148) * build(deps): Bump github.com/tendermint/tendermint from 0.35.5 to 0.35.6 (cosmos#12146) Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.35.5 to 0.35.6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/tendermint/tendermint/releases">github.com/tendermint/tendermint's releases</a>.</em></p> <blockquote> <h2>0.35.6 (WARNING: BETA SOFTWARE)</h2> <p><a href="https://github.com/tendermint/tendermint/blob/v0.35.6/CHANGELOG.md#v0.35.6">https://github.com/tendermint/tendermint/blob/v0.35.6/CHANGELOG.md#v0.35.6</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/tendermint/tendermint/blob/v0.35.6/CHANGELOG.md">github.com/tendermint/tendermint's changelog</a>.</em></p> <blockquote> <h2>v0.35.6</h2> <p>June 3, 2022</p> <h3>FEATURES</h3> <ul> <li>[migrate] <a href="https://github-redirect.dependabot.com/tendermint/tendermint/pull/8672">#8672</a> provide function for database production (backport <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8614">#8614</a>) (<a href="https://github.com/tychoish"><code>@tychoish</code></a>)</li> </ul> <h3>BUG FIXES</h3> <ul> <li>[consensus] <a href="https://github-redirect.dependabot.com/tendermint/tendermint/pull/8651">#8651</a> restructure peer catchup sleep (<a href="https://github.com/tychoish"><code>@tychoish</code></a>)</li> <li>[pex] <a href="https://github-redirect.dependabot.com/tendermint/tendermint/pull/8657">#8657</a> align max address thresholds (<a href="https://github.com/cmwaters"><code>@cmwaters</code></a>)</li> <li>[cmd] <a href="https://github-redirect.dependabot.com/tendermint/tendermint/pull/8668">#8668</a> don't used global config for reset commands (<a href="https://github.com/cmwaters"><code>@cmwaters</code></a>)</li> <li>[p2p] <a href="https://github-redirect.dependabot.com/tendermint/tendermint/pull/8681">#8681</a> shed peers from store from other networks (backport <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8678">#8678</a>) (<a href="https://github.com/tychoish"><code>@tychoish</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/tendermint/tendermint/commit/3079eb8b30002496482bcd8aed7ab236542aecd2"><code>3079eb8</code></a> Prepare Release v0.35.6 (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8685">#8685</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/0e3a3fe58bbfc0bd137eda3f82d5af8f81d4f3d0"><code>0e3a3fe</code></a> p2p: shed peers from store from other networks (backport <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8678">#8678</a>) (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8681">#8681</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/e17e6b1aaa63ecf9f71e23aa89bed1cb2d813554"><code>e17e6b1</code></a> migrate: provide function for database production (backport <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8614">#8614</a>) (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8672">#8672</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/0421f8b25e1879ca93f5be6f10e288c02ad20063"><code>0421f8b</code></a> build(deps): Bump google.golang.org/grpc from 1.46.2 to 1.47.0 (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8666">#8666</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/4faa8b72aadb01c03636c9643f6956299fb2eb0c"><code>4faa8b7</code></a> cmd: don't used global config for reset commands (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8668">#8668</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/336dc2f2c53d8a805ee35dbac99d1eec3514bda7"><code>336dc2f</code></a> chore: update version (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8634">#8634</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/e8ac37223fae22eef27c178a25bf2beed28280e0"><code>e8ac372</code></a> pex: align max address thresholds (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8657">#8657</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/a889f17e5134c9ab738ab2c0b40a6f7f4da77538"><code>a889f17</code></a> consensus: restructure peer catchup sleep (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8651">#8651</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/2b5a4de4b3877425dea2f53e5470db550ae26ca7"><code>2b5a4de</code></a> docs: add documentation for undocumented p2p metrics (backport <a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8640">#8640</a>) (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8641">#8641</a>)</li> <li><a href="https://github.com/tendermint/tendermint/commit/a85d9c5163ba4d61063c8979c712bf57611c8f05"><code>a85d9c5</code></a> build(deps): Bump github.com/spf13/viper from 1.11.0 to 1.12.0 (<a href="https://github-redirect.dependabot.com/tendermint/tendermint/issues/8631">#8631</a>)</li> <li>See full diff in <a href="https://github.com/tendermint/tendermint/compare/v0.35.5...v0.35.6">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> (cherry picked from commit 18b94de) # Conflicts: # go.mod # go.sum * fix conflict Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]>
…) (cosmos#12209) * fix: update index of crisis invariant check logs (cosmos#12208) ## Description the info log messages describing invariant checks use the index to state progress (eg. `asserting crisis invariants inv=0/15`). this simple change makes them 1-indexed (eg. `asserting crisis invariants inv=1/15`). example before: <img width="374" alt="Screen Shot 2022-06-09 at 12 06 58 PM" src="https://user-images.githubusercontent.com/14897503/172925006-8810706c-0948-4e36-85b8-22813ccc9311.png"> Closes: #XXXX --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - N/A - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - N/A - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - N/A - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - N/A - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - N/A - [x] updated the relevant documentation or specification - N/A - [x] reviewed "Files changed" and left comments if necessary - N/A - [x] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 907df32) # Conflicts: # CHANGELOG.md * fix conflict Co-authored-by: Robert Pirtle <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…12275) ## Description `ApproxRoot` return incorrect value for large `sdk.Dec` because maxApproxRootIterations is not big enough, I increase it to 300 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [x] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] confirmed `!` in the type prefix if API or client breaking change - [x] confirmed all author checklist items have been addressed - [x] reviewed state machine logic - [x] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [x] manually tested (if applicable) (cherry picked from commit 6a3d10b) Co-authored-by: khanh <[email protected]>
* fix: GetTxsEvent pagination (cosmos#12261) ## Description Closes: cosmos#11538 Also see thread after cosmos#11538 (comment) --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit c68fa3b) # Conflicts: # api/cosmos/orm/query/v1alpha1/query.pulsar.go * delete file Co-authored-by: Marie Gauthier <[email protected]> Co-authored-by: marbar3778 <[email protected]>
WalkthroughThis update primarily involves enhancing the Cosmos SDK's build process by upgrading the Go version from 1.18 to 1.19 across multiple workflow files. Additionally, modifications streamline linting configurations, introduce new release notifications, and improve module organization. The changes aim to boost performance and maintainability while ensuring compatibility with the latest libraries and frameworks. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:Keys
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (8)
UPGRADING.md (5)
32-32: Refine for conciseness and clarity.Consider rephrasing for brevity and using "these" instead of "this" for better clarity.
- Additionally, new packages have been introduced in order to further split the codebase. Aliases are available for a new API breaking migration, but it is encouraged to migrate to this new packages: + Additionally, new packages have been introduced to further split the codebase. Aliases are available for a new API-breaking migration, but it is encouraged to migrate to these new packages:Tools
LanguageTool
[style] ~32-~32: Consider a shorter alternative to avoid wordiness.
Context: ...ally, new packages have been introduced in order to further split the codebase. Aliases are...(IN_ORDER_TO_PREMIUM)
[uncategorized] ~32-~32: The determiner “these” seems more likely in this context.
Context: ...ion, but it is encouraged to migrate to this new packages: *errorsshould replac...(AI_EN_LECTOR_REPLACEMENT_DETERMINER)
91-91: Correct grammatical errors.Consider adding "a" and correcting the verb agreement for clarity.
- in favour of each module housing and providing way to modify their parameters. Each module that has parameters that are changable during runtime have an authority, + in favour of each module housing and providing a way to modify their parameters. Each module that has parameters that are changeable during runtime has an authority,Tools
LanguageTool
[uncategorized] ~91-~91: You might be missing the article “a” here.
Context: ...ur of each module housing and providing way to modify their parameters. Each module...(AI_EN_LECTOR_MISSING_DETERMINER_A)
[uncategorized] ~91-~91: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...eters that are changable during runtime have an authority, the authority can be a mo...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
92-92: Add missing comma for clarity.Consider adding a comma for better readability.
- The Param module will be maintained until April 18, 2023. At this point the module will reach end of life and be removed from the Cosmos SDK. + The Param module will be maintained until April 18, 2023. At this point, the module will reach end of life and be removed from the Cosmos SDK.Tools
LanguageTool
[typographical] ~92-~92: It appears that a comma is missing.
Context: ...aintained until April 18, 2023. At this point the module will reach end of life and b...(DURING_THAT_TIME_COMMA)
104-104: Correct grammatical error.Ensure the verb form is correct for clarity.
- now does not contains directly the [proto files](https://github.com/cosmos/cosmos-sdk/tree/release/v0.46.x/third_party/proto). + now does not contain directly the [proto files](https://github.com/cosmos/cosmos-sdk/tree/release/v0.46.x/third_party/proto).Tools
LanguageTool
[grammar] ~104-~104: The auxiliary verb ‘do’ requires the base form of the verb.
Context: ...v0.45.3/third_party/proto) now does not contains directly the [proto files](https://gith...(DID_BASEFORM)
106-106: Refine for conciseness and clarity.Consider rephrasing for brevity and correcting the phrase "copy paste" to "copy and paste".
- with `buf.build/cosmos/cosmos-sdk` as dependency, in order to avoid having to copy paste these files. + with `buf.build/cosmos/cosmos-sdk` as a dependency, to avoid having to copy and paste these files.Tools
LanguageTool
[style] ~106-~106: Consider a shorter alternative to avoid wordiness.
Context: ...build/cosmos/cosmos-sdk` as dependency, in order to avoid having to copy paste these files....(IN_ORDER_TO_PREMIUM)
[grammar] ~106-~106: Did you mean “copy and paste”?
Context: ...dependency, in order to avoid having to copy paste these files. The protos can as well be...(COPY_PASTE)
SECURITY.md (1)
16-16: LGTM! Update the abbreviation.The hyperlink update reflects the correct repository for the IAVL library. However, the abbreviation "eg." should be corrected to "e.g." to follow standard English usage.
- in for Tendermint and other lower-level libraries (eg. [IAVL](https://github.com/cosmos/iavl)). + in for Tendermint and other lower-level libraries (e.g. [IAVL](https://github.com/cosmos/iavl)).Tools
LanguageTool
[uncategorized] ~16-~16: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...ermint and other lower-level libraries (eg. IAVL)...(E_G)
Makefile (2)
70-79: Consider the impact of removing RocksDB support.The conditional checks and warnings for RocksDB support have been removed. Ensure that users who rely on RocksDB are informed and have alternatives.
Consider documenting this change in the release notes to inform users about the removal of RocksDB support.
63-63: Update all Tendermint references in the Makefile to CometBFT.The following lines in the
Makefilestill reference the old Tendermint URL and need to be updated to CometBFT:
Makefile:export TMVERSION := $(shell go list -m github.com/tendermint/tendermint | sed 's:.* ::')Makefile: -X github.com/tendermint/tendermint/version.TMCoreSemVer=$(TMVERSION)Makefile: $(mockgen_cmd) -package mocks -destination tests/mocks/tendermint_tendermint_libs_log_DB.go github.com/tendermint/tendermint/libs/log LoggerPlease update these references to ensure consistency with the new repository location.
Analysis chain
Update Tendermint URL to CometBFT.
The Tendermint URL has been updated to CometBFT, reflecting the new repository location. Ensure that this change is consistent with other references in the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all references to Tendermint have been updated to CometBFT. # Test: Search for the old Tendermint URL. Expect: No occurrences of the old URL. rg --type makefile 'github.com/tendermint/tendermint'Length of output: 86
Script:
#!/bin/bash # Description: Verify all references to Tendermint have been updated to CometBFT. # Search for the old Tendermint URL in files named Makefile. rg 'github.com/tendermint/tendermint' --glob '**/Makefile'Length of output: 390
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (45)
api/cosmos/app/v1alpha1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/auth/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/authz/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/authz/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/bank/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/bank/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/base/reflection/v1beta1/reflection_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/base/reflection/v2alpha1/reflection_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/base/tendermint/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/crisis/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/distribution/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/distribution/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/evidence/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/evidence/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/feegrant/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/feegrant/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/gov/v1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/gov/v1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/gov/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/gov/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/group/v1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/group/v1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/mint/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/nft/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/nft/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/params/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/slashing/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/slashing/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/staking/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/staking/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/tx/v1beta1/service_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/upgrade/v1beta1/query_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/upgrade/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/cosmos/vesting/v1beta1/tx_grpc.pb.gois excluded by!**/*.pb.goapi/go.sumis excluded by!**/*.sumapi/tendermint/abci/types_grpc.pb.gois excluded by!**/*.pb.goclient/grpc/node/query.pb.gois excluded by!**/*.pb.goclient/grpc/node/query.pb.gw.gois excluded by!**/*.pb.gw.goclient/grpc/tmservice/query.pb.gois excluded by!**/*.pb.goclient/grpc/tmservice/types.pb.gois excluded by!**/*.pb.goclient/v2/internal/buf.lockis excluded by!**/*.lockcontrib/rosetta/rosetta-ci/data.tar.gzis excluded by!**/*.gzcore/go.sumis excluded by!**/*.sumcosmovisor/go.sumis excluded by!**/*.sumdocs/core/baseapp_transaction-middleware.pngis excluded by!**/*.png
Files selected for processing (17)
- .github/workflows/codeql-analysis.yml (1 hunks)
- .github/workflows/cosmovisor-release.yml (1 hunks)
- .github/workflows/lint.yml (1 hunks)
- .github/workflows/release.yml (2 hunks)
- .github/workflows/sims.yml (5 hunks)
- .github/workflows/test-race.yml (4 hunks)
- .github/workflows/test.yml (7 hunks)
- .gitignore (2 hunks)
- .golangci.yml (3 hunks)
- .goreleaser.yml (1 hunks)
- Dockerfile (1 hunks)
- Makefile (6 hunks)
- README.md (2 hunks)
- RELEASE_NOTES.md (1 hunks)
- RELEASE_PROCESS.md (2 hunks)
- SECURITY.md (1 hunks)
- UPGRADING.md (1 hunks)
Files skipped from review due to trivial changes (6)
- .github/workflows/sims.yml
- .github/workflows/test.yml
- .gitignore
- README.md
- RELEASE_NOTES.md
- RELEASE_PROCESS.md
Additional context used
LanguageTool
UPGRADING.md
[style] ~32-~32: Consider a shorter alternative to avoid wordiness.
Context: ...ally, new packages have been introduced in order to further split the codebase. Aliases are...(IN_ORDER_TO_PREMIUM)
[uncategorized] ~32-~32: The determiner “these” seems more likely in this context.
Context: ...ion, but it is encouraged to migrate to this new packages: *errorsshould replac...(AI_EN_LECTOR_REPLACEMENT_DETERMINER)
[uncategorized] ~91-~91: You might be missing the article “a” here.
Context: ...ur of each module housing and providing way to modify their parameters. Each module...(AI_EN_LECTOR_MISSING_DETERMINER_A)
[uncategorized] ~91-~91: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...eters that are changable during runtime have an authority, the authority can be a mo...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
[typographical] ~92-~92: It appears that a comma is missing.
Context: ...aintained until April 18, 2023. At this point the module will reach end of life and b...(DURING_THAT_TIME_COMMA)
[style] ~97-~97: Consider a shorter alternative to avoid wordiness.
Context: ...the new implementation is calledv1. In order to submit a proposal with `submit-proposal...(IN_ORDER_TO_PREMIUM)
[grammar] ~104-~104: The auxiliary verb ‘do’ requires the base form of the verb.
Context: ...v0.45.3/third_party/proto) now does not contains directly the [proto files](https://gith...(DID_BASEFORM)
[style] ~106-~106: Consider a shorter alternative to avoid wordiness.
Context: ...build/cosmos/cosmos-sdk` as dependency, in order to avoid having to copy paste these files....(IN_ORDER_TO_PREMIUM)
[grammar] ~106-~106: Did you mean “copy and paste”?
Context: ...dependency, in order to avoid having to copy paste these files. The protos can as well be...(COPY_PASTE)
SECURITY.md
[uncategorized] ~16-~16: The abbreviation “e.g.” (= for example) requires two periods.
Context: ...ermint and other lower-level libraries (eg. IAVL)...(E_G)
Additional comments not posted (15)
.goreleaser.yml (1)
27-27: Changelog generation enabled.Changing
changelog.skipfromtruetofalseensures that a changelog is generated during the release process. This is a positive change for tracking and documenting updates..github/workflows/lint.yml (4)
4-5: Trigger added for tag pushes.Adding a trigger for tag pushes (
v*) ensures that the linting workflow runs on version tags, which is useful for maintaining code quality during releases.
20-20: Go version updated to 1.19.Updating the Go version from 1.18 to 1.19 ensures compatibility with the latest features and improvements in the Go language.
21-21: Checkout action updated toactions/checkout@v3.Switching to
actions/checkout@v3is a standard and updated approach, improving the stability of the workflow.
25-26: Specific version set for golangci-lint.Specifying
version: v1.49.0for golangci-lint ensures that a known, stable version is used, enhancing the consistency of linting results..golangci.yml (2)
14-14: Addedgofumptlinter.The addition of
gofumpthelps ensure consistent formatting, which is stricter thangofmtand can improve code readability.
41-43: New rule fornolintlintadded.The rule to enforce no leading spaces in
nolintcomments helps maintain clean and consistent code annotations..github/workflows/cosmovisor-release.yml (1)
16-16: Go version update is appropriate.The update from Go 1.18 to 1.19 ensures the workflow benefits from the latest improvements and features in Go. Make sure the rest of the codebase is compatible with Go 1.19.
Dockerfile (1)
13-13: Go version update in Dockerfile is appropriate.Updating the base image to Go 1.19-alpine ensures the Docker environment benefits from the latest Go features and improvements. Verify that the application is fully compatible with Go 1.19.
.github/workflows/release.yml (2)
18-18: Go version update is appropriate.The update from Go 1.18 to 1.19 ensures the workflow benefits from the latest improvements and features in Go. Ensure the rest of the codebase is compatible with Go 1.19.
28-45: Addition of Slack notification job is a valuable enhancement.The
release-successjob improves team communication by notifying the Slack channel upon successful release tagging. Ensure the Slack webhook and channel configurations are correct and secure..github/workflows/codeql-analysis.yml (1)
28-28: Verify compatibility with Go 1.19.The Go version has been updated to 1.19. Ensure that all dependencies and code are compatible with this version to avoid any unexpected issues.
Verification successful
No specific compatibility issues with Go 1.19 found.
The search did not reveal any deprecated or breaking changes specifically related to Go 1.19. Ensure to test the application thoroughly to confirm compatibility.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility with Go 1.19 by checking for any deprecated or breaking changes in dependencies. # Test: Search for any deprecated or breaking changes related to Go 1.19 in the codebase. rg --type go 'deprecated|breaking change' -A 5Length of output: 16208
.github/workflows/test-race.yml (1)
Line range hint
27-97:
Verify compatibility with Go 1.19 across all workflow steps.The Go version has been updated to 1.19 in multiple steps. Ensure that all steps, including building and testing, are compatible with this version.
Verification successful
No compatibility issues found with Go 1.19 in the workflow steps.
The update to Go 1.19 in the workflow
.github/workflows/test-race.ymldoes not introduce any compatibility issues based on the current codebase analysis. The deprecated features and breaking changes identified are related to the Cosmos SDK, not the Go version itself. Therefore, the workflow steps should function correctly with Go 1.19.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify compatibility with Go 1.19 across all workflow steps. # Test: Check for any deprecated or breaking changes related to Go 1.19 in the build and test scripts. rg --type go 'deprecated|breaking change' -A 5Length of output: 16208
Makefile (2)
332-342: Enhance linting process with explicit versioning.The
golangci-lintversion is now explicitly set tov1.49.0, ensuring consistency across environments. This change is beneficial for maintaining code quality.
347-350: Incorporategofumptfor consistent formatting.The inclusion of
gofumptin theformattarget enhances code consistency and quality. This change aligns with best practices for Go code formatting.
|
Seems to be a mistake, closing |
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...
Summary by CodeRabbit
New Features
UPGRADING.mdguide for developers upgrading to Cosmos SDK v0.46.x.Bug Fixes
Documentation
RELEASE_PROCESS.mdfor better accessibility.SECURITY.md.Chores
.gitignoreto include new entries and modified existing ones.Makefile.