refactor: Simplify SimulationManager setup #12153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tac0turtle
approved these changes
Jun 4, 2022
|
@ValarDragon did you meant to backport this to 0.45 or 0.46 (or both)? |
julienrbrt
approved these changes
Jun 6, 2022
alexanderbez
added
the
backport/0.46.x
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2022
(cherry picked from commit 544afb6) # Conflicts: # simapp/app.go
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2022
(cherry picked from commit 544afb6) # Conflicts: # CHANGELOG.md # simapp/app.go
alexanderbez
pushed a commit
that referenced
this pull request
Jun 6, 2022
tac0turtle
pushed a commit
that referenced
this pull request
Jun 7, 2022
* refactor: Simplify SimulationManager setup (#12153) (cherry picked from commit 544afb6) # Conflicts: # CHANGELOG.md # simapp/app.go * fix conflict * fix conflict Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Julien Robert <[email protected]>
randy75828
pushed a commit
to Switcheo/cosmos-sdk
that referenced
this pull request
Aug 10, 2022
…osmos#12159) * refactor: Simplify SimulationManager setup (cosmos#12153) (cherry picked from commit 544afb6) # Conflicts: # CHANGELOG.md # simapp/app.go * fix conflict * fix conflict Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Eengineer1
pushed a commit
to cheqd/cosmos-sdk
that referenced
this pull request
Aug 26, 2022
…osmos#12159) * refactor: Simplify SimulationManager setup (cosmos#12153) (cherry picked from commit 544afb6) # Conflicts: # CHANGELOG.md # simapp/app.go * fix conflict * fix conflict Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Julien Robert <[email protected]>
p0mvn
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Oct 13, 2022
…osmos#12159) * refactor: Simplify SimulationManager setup (cosmos#12153) (cherry picked from commit 544afb6) * fix conflict * fix conflict Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Julien Robert <[email protected]>
mattverse
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
Oct 13, 2022
…osmos#12159) (#358) * refactor: Simplify SimulationManager setup (cosmos#12153) (cherry picked from commit 544afb6) * fix conflict * fix conflict Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Julien Robert <[email protected]>
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
19 tasks
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…osmos#12159) * refactor: Simplify SimulationManager setup (cosmos#12153) (cherry picked from commit 544afb6) # Conflicts: # CHANGELOG.md # simapp/app.go * fix conflict * fix conflict Co-authored-by: Dev Ojha <[email protected]> Co-authored-by: Julien Robert <[email protected]>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to simplify the overhead of the simulation manager setup, in a non-breaking way.
Also removes some of the complexity out of trying to do this independently in your own app, by having a re-usable helper method in the module package (where it belongs) (osmosis-labs/osmosis#1664)
If this conflicts with your plans for app-wiring feel free to just close this. However, as far as I can tell, its still helpful w/ app wiring for app-specific overrides and legacy modules.
Author Checklist
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change