feat: module hash by height query #20779

czarcas7ic · 2024-06-25T21:38:12Z

Description

When a node app hashes, its very useful to be able to get each module's hash in order to determine the module(s) at fault. This PR implements a CLI query that makes it simple to get this information.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

New Features
- Introduced a new CLI command to query and retrieve module hashes at a specific blockchain height for debugging and verification purposes.
- Enhanced debugging capabilities by allowing users to gain insights into module states associated with different heights.

coderabbitai · 2024-06-25T21:38:18Z

Walkthrough

The latest update to the cosmos-sdk introduces a new CLI feature that allows users to query and retrieve module hashes at a specified blockchain height. This enhancement improves debugging and verification processes by offering detailed insights into the states of various modules at specific points in time, thus facilitating better traceability and analysis of module interactions.

Changes

File	Change Summary
`CHANGELOG.md`	Added a summary describing the new CLI feature for querying module hashes by height.
`server/module_hash_by_height.go`	Introduced `ModuleHashByHeightQuery` and supporting functions to fetch and sort module hashes.
`server/util.go`	Updated `AddCommands` to include `ModuleHashByHeightQuery` in the list of commands.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant CLI as CLI
    participant SV as Server
    participant DB as Database

    U->>CLI: Request module hash at height X
    CLI->>SV: `ModuleHashByHeightQuery`
    SV->>DB: Fetch module hashes for height X
    DB->>SV: Return module hashes
    SV->>CLI: Return formatted module hashes
    CLI->>U: Output module hashes to user

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 3

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 929803d and cebf849.

Files selected for processing (2)

CHANGELOG.md (1 hunks)
x/genutil/client/cli/module_hash_by_height.go (1 hunks)

Additional context used

Path-based instructions (2)

x/genutil/client/cli/module_hash_by_height.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Markdownlint

CHANGELOG.md

73-73: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

74-74: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

78-78: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

79-79: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

80-80: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

81-81: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

86-86: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

131-131: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

132-132: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

133-133: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

137-137: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

140-140: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

141-141: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

142-142: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

149-149: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

159-159: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

161-161: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

164-164: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

183-183: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

184-184: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

186-186: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

187-187: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

240-240: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

241-241: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

242-242: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

406-406: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

409-409: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

431-431: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

432-432: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

445-445: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

477-477: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

478-478: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

479-479: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

480-480: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

482-482: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

483-483: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

484-484: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

485-485: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

499-499: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

501-501: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

503-503: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

505-505: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

508-508: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

509-509: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

510-510: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

518-518: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

519-519: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

521-521: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

522-522: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

524-524: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

525-525: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

526-526: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

528-528: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

529-529: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

537-537: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

548-548: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

549-549: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

550-550: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

556-556: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

557-557: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

558-558: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

564-564: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

580-580: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

581-581: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

582-582: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

583-583: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

584-584: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

585-585: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

590-590: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

591-591: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

592-592: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

593-593: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

600-600: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

601-601: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

602-602: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

636-636: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

637-637: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

638-638: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

639-639: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

644-644: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

645-645: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

793-793: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

936-936: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

957-957: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

960-960: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1042-1042: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1043-1043: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1044-1044: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1045-1045: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1046-1046: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1047-1047: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1144-1144: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1230-1230: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1276-1276: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1282-1282: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1283-1283: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1284-1284: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1285-1285: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1286-1286: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1287-1287: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1387-1387: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1512-1512: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1513-1513: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1514-1514: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1515-1515: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1516-1516: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1517-1517: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1518-1518: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1519-1519: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1522-1522: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1523-1523: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1524-1524: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1525-1525: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1526-1526: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1527-1527: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1776-1776: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1777-1777: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1778-1778: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1779-1779: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1780-1780: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1781-1781: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1891-1891: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2228-2228: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2229-2229: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2230-2230: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2233-2233: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2234-2234: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2235-2235: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2257-2257: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2258-2258: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2259-2259: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2260-2260: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2261-2261: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2269-2269: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2270-2270: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2271-2271: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2272-2272: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2273-2273: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2275-2275: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2276-2276: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2277-2277: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2604-2604: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2605-2605: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2606-2606: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2607-2607: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2608-2608: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2610-2610: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2612-2612: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2613-2613: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2614-2614: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2615-2615: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2616-2616: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2617-2617: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2619-2619: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2620-2620: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2621-2621: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2624-2624: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2625-2625: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2626-2626: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2627-2627: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2628-2628: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2631-2631: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2634-2634: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2637-2637: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2638-2638: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2641-2641: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2648-2648: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2649-2649: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2650-2650: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2651-2651: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2652-2652: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2654-2654: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2655-2655: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2656-2656: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2657-2657: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2658-2658: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2659-2659: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2660-2660: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2661-2661: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2662-2662: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2665-2665: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2666-2666: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2667-2667: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2668-2668: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2669-2669: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2670-2670: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2677-2677: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2678-2678: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2679-2679: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2680-2680: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2687-2687: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2689-2689: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2691-2691: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2692-2692: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2693-2693: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2694-2694: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2695-2695: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2696-2696: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2697-2697: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2698-2698: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2699-2699: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2700-2700: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2701-2701: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2702-2702: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2703-2703: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2704-2704: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2705-2705: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2706-2706: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2707-2707: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2708-2708: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2709-2709: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2710-2710: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2711-2711: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2712-2712: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2713-2713: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2714-2714: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2715-2715: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2716-2716: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2717-2717: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2719-2719: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2720-2720: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2722-2722: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2723-2723: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2724-2724: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2725-2725: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2726-2726: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2727-2727: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2728-2728: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2731-2731: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2732-2732: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2734-2734: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2735-2735: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2738-2738: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2739-2739: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2740-2740: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2741-2741: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2742-2742: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2743-2743: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2744-2744: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2745-2745: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2747-2747: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2748-2748: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2749-2749: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2755-2755: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2758-2758: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2764-2764: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2772-2772: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2773-2773: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2774-2774: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2775-2775: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2783-2783: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2790-2790: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2791-2791: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2798-2798: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2800-2800: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2804-2804: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2805-2805: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2807-2807: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2815-2815: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2817-2817: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2818-2818: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2824-2824: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2832-2832: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2833-2833: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2834-2834: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2835-2835: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2836-2836: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2837-2837: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2838-2838: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2839-2839: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2840-2840: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2841-2841: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2842-2842: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2843-2843: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2844-2844: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2845-2845: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2847-2847: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2848-2848: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2850-2850: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2851-2851: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2852-2852: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2853-2853: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2854-2854: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2855-2855: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2856-2856: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2857-2857: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2858-2858: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2859-2859: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2861-2861: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2862-2862: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2865-2865: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2866-2866: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2867-2867: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2868-2868: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2869-2869: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2870-2870: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2871-2871: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2872-2872: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2873-2873: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2874-2874: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2875-2875: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2876-2876: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2877-2877: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2878-2878: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2879-2879: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2880-2880: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2885-2885: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2886-2886: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2887-2887: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2888-2888: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2889-2889: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2890-2890: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2892-2892: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2894-2894: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2908-2908: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2909-2909: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2910-2910: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2915-2915: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2916-2916: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2917-2917: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2921-2921: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2922-2922: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2923-2923: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2924-2924: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2925-2925: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2926-2926: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2929-2929: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2930-2930: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2931-2931: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2932-2932: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2933-2933: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2934-2934: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2935-2935: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2936-2936: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2937-2937: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2939-2939: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2941-2941: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2943-2943: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2948-2948: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2949-2949: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2950-2950: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2951-2951: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2952-2952: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2953-2953: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2954-2954: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2955-2955: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2956-2956: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2957-2957: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2958-2958: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2959-2959: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2960-2960: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2961-2961: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2962-2962: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2963-2963: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2964-2964: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2965-2965: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2966-2966: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2967-2967: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2968-2968: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

193-193: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

237-237: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

1146-1146: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1936-1936: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1694-1694: null (MD034, no-bare-urls)
Bare URL used

1724-1724: null (MD034, no-bare-urls)
Bare URL used

2671-2671: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2759-2759: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2761-2761: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2766-2766: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2768-2768: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2778-2778: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2780-2780: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2785-2785: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2793-2793: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2810-2810: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2812-2812: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2820-2820: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2826-2826: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2896-2896: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2899-2899: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2902-2902: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2904-2904: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2944-2944: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

1065-1065: null (MD038, no-space-in-code)
Spaces inside code span elements

2712-2712: null (MD038, no-space-in-code)
Spaces inside code span elements

2712-2712: null (MD038, no-space-in-code)
Spaces inside code span elements

Additional comments not posted (1)

x/genutil/client/cli/module_hash_by_height.go (1)

104-107: Validate File Path Handling in openDB

The openDB function constructs a file path and opens a database. It's crucial to ensure that:

Path Handling: The function correctly constructs the path using filepath.Join, which is good practice to avoid path manipulation vulnerabilities.

Error Handling: Ensure that the error handling is robust, especially in scenarios where the database cannot be opened due to permissions or corruption.

The use of filepath.Join for path construction adheres to best practices in handling file paths securely.

CHANGELOG.md

x/genutil/client/cli/module_hash_by_height.go

facundomedica · 2024-06-26T10:22:54Z

This looks very helpful indeed, I can think of 2 issues this can relate to:

facundomedica · 2024-06-26T10:24:27Z

x/genutil/client/cli/module_hash_by_height.go

+			}
+
+			// Print the CommitInfo to the console.
+			fmt.Println(commitInfoForHeight.String())


nit: allow json

Added json functionality here, I believe it was done to standard but would appreciate an ack 8e2f8bb

facundomedica · 2024-06-26T10:24:44Z

x/genutil/client/cli/module_hash_by_height.go

+)
+
+// ModuleHashByHeightQuery retrieves the module hashes at a given height.
+func ModuleHashByHeightQuery[T servertypes.Application](appCreator servertypes.AppCreator[T]) *cobra.Command {


where is this command being added?

I did not add it as I wasn't sure if this was desired as a default and instead have the apps import it themselves, but I can add as a default query for all apps if desired!

I moved it to server here to have access to appCreator and registered it as a default CLI cmd 39ef821

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cebf849 and 268af2e.

Files selected for processing (1)

CHANGELOG.md (1 hunks)

Additional context used

Path-based instructions (1)

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Markdownlint

CHANGELOG.md

73-73: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

74-74: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

78-78: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

79-79: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

80-80: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

81-81: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

86-86: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

131-131: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

132-132: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

133-133: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

137-137: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

140-140: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

141-141: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

142-142: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

149-149: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

159-159: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

161-161: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

164-164: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

183-183: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

184-184: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

186-186: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

187-187: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

240-240: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

241-241: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

242-242: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

406-406: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

409-409: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

431-431: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

432-432: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

445-445: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

477-477: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

478-478: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

479-479: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

480-480: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

482-482: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

483-483: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

484-484: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

485-485: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

499-499: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

501-501: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

503-503: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

505-505: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

508-508: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

509-509: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

510-510: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

518-518: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

519-519: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

521-521: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

522-522: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

524-524: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

525-525: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

526-526: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

528-528: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

529-529: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

537-537: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

548-548: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

549-549: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

550-550: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

556-556: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

557-557: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

558-558: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

564-564: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

580-580: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

581-581: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

582-582: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

583-583: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

584-584: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

585-585: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

590-590: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

591-591: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

592-592: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

593-593: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

600-600: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

601-601: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

602-602: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

636-636: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

637-637: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

638-638: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

639-639: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

644-644: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

645-645: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

793-793: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

936-936: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

957-957: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

960-960: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1042-1042: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1043-1043: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1044-1044: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1045-1045: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1046-1046: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1047-1047: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1144-1144: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1230-1230: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1276-1276: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1282-1282: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1283-1283: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1284-1284: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1285-1285: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1286-1286: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1287-1287: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1387-1387: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1512-1512: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1513-1513: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1514-1514: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1515-1515: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1516-1516: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1517-1517: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1518-1518: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1519-1519: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1522-1522: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1523-1523: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1524-1524: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1525-1525: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1526-1526: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1527-1527: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

1776-1776: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1777-1777: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1778-1778: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1779-1779: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1780-1780: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1781-1781: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

1891-1891: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2228-2228: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2229-2229: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2230-2230: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2233-2233: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2234-2234: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2235-2235: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2257-2257: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2258-2258: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2259-2259: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2260-2260: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2261-2261: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2269-2269: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2270-2270: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2271-2271: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2272-2272: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2273-2273: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2275-2275: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2276-2276: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2277-2277: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2604-2604: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2605-2605: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2606-2606: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2607-2607: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2608-2608: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2610-2610: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2612-2612: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2613-2613: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2614-2614: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2615-2615: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2616-2616: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2617-2617: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2619-2619: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2620-2620: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2621-2621: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2624-2624: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2625-2625: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2626-2626: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2627-2627: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2628-2628: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2631-2631: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2634-2634: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2637-2637: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2638-2638: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2641-2641: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2648-2648: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2649-2649: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2650-2650: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2651-2651: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2652-2652: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2654-2654: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2655-2655: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2656-2656: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2657-2657: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2658-2658: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2659-2659: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2660-2660: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2661-2661: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2662-2662: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2665-2665: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2666-2666: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2667-2667: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2668-2668: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2669-2669: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2670-2670: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2677-2677: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2678-2678: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2679-2679: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2680-2680: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2687-2687: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2689-2689: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2691-2691: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2692-2692: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2693-2693: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2694-2694: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2695-2695: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2696-2696: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2697-2697: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2698-2698: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2699-2699: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2700-2700: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2701-2701: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2702-2702: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2703-2703: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2704-2704: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2705-2705: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2706-2706: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2707-2707: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2708-2708: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2709-2709: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2710-2710: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2711-2711: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2712-2712: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2713-2713: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2714-2714: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2715-2715: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2716-2716: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2717-2717: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2719-2719: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2720-2720: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2722-2722: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2723-2723: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2724-2724: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2725-2725: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2726-2726: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2727-2727: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2728-2728: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2731-2731: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2732-2732: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2734-2734: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2735-2735: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2738-2738: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2739-2739: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2740-2740: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2741-2741: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2742-2742: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2743-2743: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2744-2744: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2745-2745: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2747-2747: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2748-2748: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2749-2749: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2755-2755: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2758-2758: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2764-2764: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2772-2772: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2773-2773: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2774-2774: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2775-2775: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2783-2783: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2790-2790: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2791-2791: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2798-2798: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2800-2800: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2804-2804: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2805-2805: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2807-2807: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2815-2815: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2817-2817: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2818-2818: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2824-2824: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2832-2832: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2833-2833: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2834-2834: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2835-2835: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2836-2836: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2837-2837: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2838-2838: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2839-2839: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2840-2840: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2841-2841: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2842-2842: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2843-2843: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2844-2844: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2845-2845: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2847-2847: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2848-2848: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2850-2850: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2851-2851: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2852-2852: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2853-2853: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2854-2854: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2855-2855: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2856-2856: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2857-2857: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2858-2858: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2859-2859: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2861-2861: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2862-2862: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2865-2865: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2866-2866: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2867-2867: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2868-2868: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2869-2869: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2870-2870: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2871-2871: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2872-2872: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2873-2873: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2874-2874: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2875-2875: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2876-2876: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2877-2877: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2878-2878: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2879-2879: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2880-2880: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2885-2885: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2886-2886: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2887-2887: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2888-2888: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2889-2889: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2890-2890: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2892-2892: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2894-2894: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2908-2908: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2909-2909: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2910-2910: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2915-2915: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2916-2916: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2917-2917: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2921-2921: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2922-2922: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2923-2923: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2924-2924: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2925-2925: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2926-2926: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2929-2929: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2930-2930: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2931-2931: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2932-2932: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2933-2933: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2934-2934: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2935-2935: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2936-2936: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2937-2937: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2939-2939: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2941-2941: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2943-2943: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2948-2948: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2949-2949: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2950-2950: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2951-2951: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2952-2952: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2953-2953: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2954-2954: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2955-2955: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2956-2956: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2957-2957: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2958-2958: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2959-2959: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2960-2960: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2961-2961: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2962-2962: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2963-2963: Expected: 4; Actual: 8 (MD007, ul-indent)
Unordered list indentation

2964-2964: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2965-2965: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2966-2966: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2967-2967: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

2968-2968: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation

193-193: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

237-237: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

1146-1146: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1936-1936: null (MD024, no-duplicate-heading)
Multiple headings with the same content

1694-1694: null (MD034, no-bare-urls)
Bare URL used

1724-1724: null (MD034, no-bare-urls)
Bare URL used

2671-2671: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2759-2759: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2761-2761: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2766-2766: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2768-2768: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2778-2778: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2780-2780: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2785-2785: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2793-2793: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2810-2810: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2812-2812: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2820-2820: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2826-2826: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2896-2896: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2899-2899: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2902-2902: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2904-2904: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

2944-2944: null (MD037, no-space-in-emphasis)
Spaces inside emphasis markers

1065-1065: null (MD038, no-space-in-code)
Spaces inside code span elements

2712-2712: null (MD038, no-space-in-code)
Spaces inside code span elements

2712-2712: null (MD038, no-space-in-code)
Spaces inside code span elements

Additional comments not posted (1)

CHANGELOG.md (1)
65-65: Review the CHANGELOG entry for clarity and accuracy.

The entry for the new module-hash-by-height command is clear and directly references the PR. However, consider adding more detail about how this command enhances debugging capabilities or impacts users directly to provide more context to the changelog readers.
- * (cli) [#20779](https://github.com/cosmos/cosmos-sdk/pull/20779) Added `module-hash-by-height` command to query and retrieve module hashes at a specified blockchain height, enhancing debugging capabilities.
+ * (cli) [#20779](https://github.com/cosmos/cosmos-sdk/pull/20779) Added `module-hash-by-height` command to query and retrieve module hashes at a specified blockchain height. This feature aids in debugging by allowing users to pinpoint changes in module states across different blockchain heights.

czarcas7ic · 2024-06-26T16:23:59Z

Thanks for the quick review! Should have addressed all open concerns.

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 268af2e and d9f8467.

Files selected for processing (2)

server/module_hash_by_height.go (1 hunks)
server/util.go (1 hunks)

Additional context used

Path-based instructions (2)

server/module_hash_by_height.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

server/util.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (3)

server/module_hash_by_height.go (2)

22-71: Review of ModuleHashByHeightQuery function

This function successfully defines a new CLI command to query module hashes by block height. The use of generics ([T servertypes.Application]) is appropriate, ensuring type safety and flexibility. The command setup with cobra is correctly implemented, including error handling and output formatting options. However, consider adding error messages for user clarity when the input height argument is invalid or when the database cannot be accessed.

122-125: Review of openDB function

The function openDB is succinct and effectively handles the database connection setup. It is good practice to centralize database connection logic as done here. However, ensure that the database path construction is robust against path traversal attacks by validating or sanitizing inputs.

server/util.go (1)

357-357: Integration of ModuleHashByHeightQuery in AddCommands

The addition of ModuleHashByHeightQuery(appCreator) to the list of commands is correctly implemented. It ensures that the new functionality is accessible via the CLI. Ensure that this new command is documented appropriately in the user guide or help sections of the CLI to aid user adoption.

server/module_hash_by_height.go

czarcas7ic · 2024-07-15T17:30:42Z

@alpe Responded to all comments, thanks for the thorough review!

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 06dd7cd and 61dd9e3.

Files selected for processing (1)

CHANGELOG.md (1 hunks)

Additional context used

Path-based instructions (1)

CHANGELOG.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Additional comments not posted (1)

CHANGELOG.md (1)

64-64: Entry is clear and well-structured.

The changelog entry for the module-hash-by-height command is concise and follows the format of other entries. It effectively communicates the purpose and benefit of the new feature.

Comments implemented

Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Marko <[email protected]> (cherry picked from commit 4e97c49)

Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Marko <[email protected]> (cherry picked from commit 4e97c49) # Conflicts: # CHANGELOG.md # server/util.go

Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Julien Robert <[email protected]>

Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: marbar3778 <[email protected]>

Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Marko <[email protected]>

* build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (cosmos#19811) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(x/gov): emit proposer address in submit proposal event (backport cosmos#19842) (cosmos#19844) Co-authored-by: Aryan Tikarya <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(x/gov): emit depositor in `proposal_deposit` event (backport cosmos#19853) (cosmos#19859) Co-authored-by: Kien <[email protected]> Co-authored-by: Julien Robert <[email protected]> * reuse fromAddrString (minor cleanup) (cosmos#19881) * feat(client): replace `event-query-tx-for` with `wait-tx` (backport cosmos#19870) (cosmos#19887) * feat(server): add custom start handler (backport cosmos#19854) (cosmos#19884) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (cosmos#19925) * build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#19985) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * fix(client/v2): add encoder for `cosmos.base.v1beta1.DecCoin` (backport cosmos#19976) (cosmos#20001) Co-authored-by: Julien Robert <[email protected]> * fix(mempool): use no-op mempool as default (backport cosmos#19970) (cosmos#20008) Co-authored-by: Tom <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat: Conditionally emit metrics based on enablement (backport cosmos#19903) (cosmos#20017) Co-authored-by: Lucas Francisco López <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/bank): align query with multi denoms for send-enabled (backport cosmos#20028) (cosmos#20029) Co-authored-by: mmsqe <[email protected]> * fix: Implement gogoproto customtype to secp256r1 keys (backport cosmos#20027) (cosmos#20031) Co-authored-by: Facundo Medica <[email protected]> * fix(client/v2): respect output format from client ctx (backport cosmos#20033) (cosmos#20046) Co-authored-by: mmsqe <[email protected]> * build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/bank): support depinject for send restrictions (backport cosmos#20014) (cosmos#20024) * fix(baseapp): don't share global gas meter in tx execution (backport cosmos#19616) (cosmos#20050) * fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069) Co-authored-by: Facundo Medica <[email protected]> * build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to 1.0.0-beta.5 (cosmos#20095) * feat(client/v2): implement version filtering using annotation (backport cosmos#20083) (cosmos#20099) Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.6 (cosmos#19998) * fix: use timestamp for sim log file name (backport cosmos#20108) (cosmos#20111) Co-authored-by: mmsqe <[email protected]> * fix(x/authz,x/feegrant): check blocked address (cosmos#20102) * chore: update v0.50.6 release notes (cosmos#20124) * build(deps): bump sdk in modules (cosmos#20126) * docs(gas/fees): Update block gas documentation (backport cosmos#20128) (cosmos#20131) Co-authored-by: samricotta <[email protected]> * fix(baseapp): avoid header height overwrite block height (backport cosmos#20107) (cosmos#20129) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs: fix broken link (backport cosmos#20133) (cosmos#20138) * build(deps): bump modules in simapp (cosmos#20137) * build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (cosmos#20152) * docs: add authz reference info in the circuit antehandler (backport cosmos#20146) (cosmos#20155) Co-authored-by: Reece Williams <[email protected]> * fix(testsuite/sims): set all signatures (backport cosmos#20151) (cosmos#20185) Co-authored-by: Leon <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (cosmos#20206) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(server): bootstrap-state command can't parse latest genesis format (backport cosmos#20020) (cosmos#20045) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: remove txs from mempool when antehandler fails in recheck (backport cosmos#20144) (cosmos#20251) Co-authored-by: Marko <[email protected]> * feat(baseapp): expose grpc query router via depinject. (cosmos#20264) * feat(client/v2): override short description in generated command (backport cosmos#20266) (cosmos#20269) Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(runtime): Add missing NewTransientStoreService (backport cosmos#20261) (cosmos#20327) Co-authored-by: beer-1 <[email protected]> * fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323) (cosmos#20329) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(client/v2): correctly check subcommand short descriptions (backport cosmos#20330) (cosmos#20340) * build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338) * style: Fix gov query proposals examples syntax (backport cosmos#20353) (cosmos#20357) * feat(client): add consensus address for debug cmd (backport cosmos#20328) (cosmos#20366) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(client): overwrite client context instead of setting new one (backport cosmos#20356) (cosmos#20383) Co-authored-by: Shude Li <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix: correctly assign `execModeSimulate` to context for `simulateTx` (backport cosmos#20342) (cosmos#20346) Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: update diagram to be shown properly (backport cosmos#20454) (cosmos#20460) Co-authored-by: tianyeyouyou <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: fix note blocks display failure (backport cosmos#20457) (cosmos#20459) Co-authored-by: cocoyeal <[email protected]> * docs: update link contents (backport cosmos#20437) (cosmos#20462) Co-authored-by: PolyMa <[email protected]> * fix(x/consensus): harden consensus params proposal (cosmos#20381) Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * docs: add docs on permissions (backport cosmos#20526) (cosmos#20527) Co-authored-by: Marko <[email protected]> * chore(x/upgrade): bump vulnerable `go-getter` library (cosmos#20530) * chore: prepare v0.50.7 (cosmos#20475) * build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590) * docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627) Co-authored-by: samricotta <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660) Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: marbar3778 <[email protected]> * docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711) * feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712) Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]> * feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727) Co-authored-by: Julien Robert <[email protected]> * docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751) * feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.8 (cosmos#20910) * chore(simapp): use tagged version (cosmos#20951) * fix: include pagination.key at reverse mode (backport cosmos#20939) (cosmos#20954) Co-authored-by: beer-1 <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.9 to 0.38.10 (cosmos#20960) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(client/v2): use (PREFIX)_HOME instead of NODE_HOME (backport cosmos#20964) (cosmos#20970) Co-authored-by: Julien Robert <[email protected]> * fix(client/grpc): `node.NewQueryServer` method not setting `cfg` (backport cosmos#20969) (cosmos#20973) * fix: NewIntegrationApp does not write default genesis to state (backport cosmos#21006) (cosmos#21008) Co-authored-by: son trinh <[email protected]> * fix(crypto): revert cosmos#20438 (cosmos#21019) * feat: use depinject v1.0.0 (cosmos#21000) * fix(runtime): remove `appv1alpha1.Config` from runtime (backport cosmos#21042) (cosmos#21080) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat: check latest block if no arg in `q block` and `q block-results` (backport cosmos#21084) (cosmos#21111) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * fix(simapp): concurrent map writes when calling GetSigners (backport cosmos#21073) (cosmos#21130) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Facundo <[email protected]> * docs: Fix cli usage examples (backport cosmos#21150) (cosmos#21154) Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: bring in v0.13.x x/tx in release/v0.50.x (cosmos#21158) * build(deps): Bump cosmossdk.io/x/tx from 0.13.3 to 0.13.4 (cosmos#21170) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): return events from preblocker in FinalizeBlockResponse (backport cosmos#21159) (cosmos#21162) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]> * chore: prepare v0.50.9 (cosmos#21163) * ci: attempt to fix goreleaser (backport cosmos#21194) (cosmos#21196) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/log from 1.3.1 to 1.4.0 (cosmos#21209) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * chore: backport NewMemStoreService method (cosmos#21212) * build(deps): Bump github.com/cosmos/gogoproto from 1.5.0 to 1.6.0 (cosmos#21234) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat: module hash by height query (backport cosmos#20779) (cosmos#21247) Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: marbar3778 <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.10 to 0.38.11 (cosmos#21264) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * feat(confix): allow customization of migration plan (backport cosmos#21202) (cosmos#21268) Co-authored-by: Tom <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/gogoproto from 1.6.0 to 1.7.0 (cosmos#21294) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp)!: Halt at height now does not produce the halt height block (backport cosmos#21256) (cosmos#21323) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Facundo <[email protected]> * chore: bring in core v0.11.x (v0.50 compatible) to v0.50 (cosmos#21298) * docs: rename app v2 to app di when talking about runtime v0 (backport cosmos#21329) (cosmos#21335) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump cosmossdk.io/log from 1.4.0 to 1.4.1 (cosmos#21351) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * docs: fix outdated link (backport cosmos#21397) (cosmos#21400) Co-authored-by: KI <[email protected]> * feat(x/bank): add origin address in event multisend (backport cosmos#21460) (cosmos#21465) Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cosmos/ics23/go from 0.10.0 to 0.11.0 (cosmos#21473) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(baseapp): preblock events are not emmitted correctly (backport cosmos#21444) (cosmos#21458) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/consensus)!: update cons params parsing checks (backport cosmos#21484) (cosmos#21493) Co-authored-by: MSalopek <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(types/mempool): fix slice init length (backport cosmos#21494) (cosmos#21519) Co-authored-by: dropbigfish <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): Bump github.com/cometbft/cometbft from 0.38.11 to 0.38.12 (cosmos#21535) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <[email protected]> * feat(x/genutil): bulk add genesis accounts (backport cosmos#21372) (cosmos#21544) Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(mempool): data race in mempool prepare proposal handler (backport cosmos#21413) (cosmos#21541) Co-authored-by: yihuang <[email protected]> Co-authored-by: Julien Robert <[email protected]> * build(deps): bump iavl in cosmossdk.io/store 1.1.x (cosmos#21574) * docs(x/evidence): fix evidence module subcommands help message (backport cosmos#21589) (cosmos#21592) * docs(client/debug): correct and improve `debug pubkey-raw` command example (backport cosmos#21594) (cosmos#21600) Co-authored-by: lilasxie <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(client/debug): correct `debug raw-bytes` command example (backport cosmos#21671) (cosmos#21676) Co-authored-by: lilasxie <[email protected]> Co-authored-by: Julien Robert <[email protected]> * docs(x/authz): update grant docs (backport cosmos#21677) (cosmos#21700) Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: Akhil Kumar P <[email protected]> * feat(x/genutil): add better error messages for genesis validation (backport cosmos#21701) (cosmos#21708) Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: marbar3778 <[email protected]> * feat(types/collections): add `LegacyDec` collection value (backport cosmos#21693) (cosmos#21724) Co-authored-by: John Letey <[email protected]> Co-authored-by: sontrinh16 <[email protected]> * docs: demonstrate how to wire custom ante handlers in 0.50 app_di (cosmos#21767) * docs(x/circuit): display correct example (backport cosmos#21768) (cosmos#21773) Co-authored-by: Julien Robert <[email protected]> * fix(runtime): fix option order (backport cosmos#21769) (cosmos#21771) Co-authored-by: Julien Robert <[email protected]> * chore: prepare v0.50.10 (cosmos#21498) * feat(x/tx): add `aminoNameAsTypeURL` option in aminojson encoder (backport cosmos#21712) (cosmos#21798) Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): use x/tx `AminoNameAsTypeURL` option in 0.50 (cosmos#21801) * feat(testutil/integration): allow to pass baseapp options (backport cosmos#21816) (cosmos#21818) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]> * chore: correct date cl v0.50.10 (cosmos#21832) * feat(crypto/keyring): add Linux's keyctl support (backport cosmos#21653) (cosmos#21840) Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(x/staking): query redelegation command (backport cosmos#21856) (cosmos#21861) Co-authored-by: Akhil Kumar P <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore(docs): rename merlin to simapp (backport cosmos#21884) (cosmos#21886) Co-authored-by: Marko <[email protected]> Co-authored-by: marbar3778 <[email protected]> * fix(cli): avoid id isn't supported error when query address-by-acc-num (backport cosmos#21919) (cosmos#21922) Co-authored-by: mmsqe <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(sims): Skip sims test when running dry on validators (backport cosmos#21906) (cosmos#21910) Co-authored-by: Alexander Peters <[email protected]> Co-authored-by: Julien Robert <[email protected]> * fix(client/v2): correctly handle enhanced sub commands (backport cosmos#21809) (cosmos#21930) Co-authored-by: John Letey <[email protected]> Co-authored-by: Julien Robert <[email protected]> * feat(client/v2): improve error message on enums (backport cosmos#21936) (cosmos#21938) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> * chore: regenerate addrbook.json for in-place-testnet (backport cosmos#21941) (cosmos#21947) Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Julien Robert <[email protected]> * align thresholdStringEncoder --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Aryan Tikarya <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Kien <[email protected]> Co-authored-by: yihuang <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Lucas Francisco López <[email protected]> Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: samricotta <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: Leon <[email protected]> Co-authored-by: sontrinh16 <[email protected]> Co-authored-by: Marko <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: beer-1 <[email protected]> Co-authored-by: Shude Li <[email protected]> Co-authored-by: Damian Nolan <[email protected]> Co-authored-by: tianyeyouyou <[email protected]> Co-authored-by: cocoyeal <[email protected]> Co-authored-by: PolyMa <[email protected]> Co-authored-by: Sergio Mena <[email protected]> Co-authored-by: Daniel Wedul <[email protected]> Co-authored-by: Hieu Vu <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Chenqun Lu <[email protected]> Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: KI <[email protected]> Co-authored-by: MSalopek <[email protected]> Co-authored-by: dropbigfish <[email protected]> Co-authored-by: Reece Williams <[email protected]> Co-authored-by: lilasxie <[email protected]> Co-authored-by: Eric Mokaya <[email protected]> Co-authored-by: Akhil Kumar P <[email protected]> Co-authored-by: John Letey <[email protected]> Co-authored-by: Alessio Treglia <[email protected]> Co-authored-by: Alexander Peters <[email protected]>

module hash by height query

0836685

github-actions bot added C:CLI C:x/genutil genutil module issues labels Jun 25, 2024

czarcas7ic added 2 commits June 25, 2024 15:39

add changelog

a289320

correct comment

0f9d159

czarcas7ic mentioned this pull request Jun 25, 2024

feat: module hash by height query osmosis-labs/osmosis#8427

Merged

czarcas7ic added 2 commits June 25, 2024 15:59

lint

91e9438

lint order

cebf849

czarcas7ic marked this pull request as ready for review June 25, 2024 22:40

czarcas7ic requested a review from a team as a code owner June 25, 2024 22:40

coderabbitai bot reviewed Jun 25, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

x/genutil/client/cli/module_hash_by_height.go Outdated Show resolved Hide resolved

x/genutil/client/cli/module_hash_by_height.go Outdated Show resolved Hide resolved

facundomedica reviewed Jun 26, 2024

View reviewed changes

tac0turtle assigned alpe, facundomedica, tac0turtle, julienrbrt and sontrinh16 Jun 26, 2024

add more detail to changelog entry

268af2e

coderabbitai bot reviewed Jun 26, 2024

View reviewed changes

move to server and make default

39ef821

github-actions bot removed C:CLI C:x/genutil genutil module issues labels Jun 26, 2024

czarcas7ic and others added 3 commits June 26, 2024 10:15

Merge branch 'main' into adam/module-hash-by-height

c5bc58e

output flag to format json

8e2f8bb

remove comments

d9f8467

coderabbitai bot reviewed Jun 26, 2024

View reviewed changes

server/module_hash_by_height.go Outdated Show resolved Hide resolved

czarcas7ic and others added 8 commits July 15, 2024 11:06

Merge branch 'main' into adam/module-hash-by-height

f983727

rename verbose file

2b586e1

use example attribute

425db57

add more context to error

bd42bd8

use existing OpenDB method

9c01f7c

remove osmosisd from error message

ccb2582

add timestamp

660aa8d

use print proto instead of manually defining prints

3dc6775

tac0turtle requested a review from alpe July 18, 2024 08:50

tac0turtle added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Aug 9, 2024

Merge branch 'main' into adam/module-hash-by-height

f883653

tac0turtle enabled auto-merge August 9, 2024 15:23

Merge branch 'main' into adam/module-hash-by-height

61dd9e3

coderabbitai bot reviewed Aug 9, 2024

View reviewed changes

julienrbrt approved these changes Aug 10, 2024

View reviewed changes

tac0turtle added this pull request to the merge queue Aug 10, 2024

Merged via the queue into main with commit 4e97c49 Aug 10, 2024
76 checks passed

tac0turtle deleted the adam/module-hash-by-height branch August 10, 2024 04:45

mergify bot pushed a commit that referenced this pull request Aug 10, 2024

feat: module hash by height query (#20779)

ffdec07

Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Marko <[email protected]> (cherry picked from commit 4e97c49)

This was referenced Aug 10, 2024

feat: module hash by height query (backport #20779) #21246

Merged

feat: module hash by height query (backport #20779) #21247

Merged

tac0turtle pushed a commit that referenced this pull request Aug 10, 2024

feat: module hash by height query (backport #20779) (#21246)

5bd3049

Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: Julien Robert <[email protected]>

tac0turtle added a commit that referenced this pull request Aug 10, 2024

feat: module hash by height query (backport #20779) (#21247)

8c5f521

Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: marbar3778 <[email protected]>

spoo-bar pushed a commit to noble-assets/cosmos-sdk that referenced this pull request Aug 12, 2024

feat: module hash by height query (cosmos#20779)

4051db9

Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Marko <[email protected]>

spoo-bar mentioned this pull request Aug 12, 2024

feat: backport module hash query noble-assets/cosmos-sdk#3

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: module hash by height query #20779

feat: module hash by height query #20779

czarcas7ic commented Jun 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 25, 2024 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

facundomedica commented Jun 26, 2024

facundomedica Jun 26, 2024

czarcas7ic Jun 26, 2024

facundomedica Jun 26, 2024

czarcas7ic Jun 26, 2024

czarcas7ic Jun 26, 2024

coderabbitai bot left a comment

czarcas7ic commented Jun 26, 2024

coderabbitai bot left a comment

czarcas7ic commented Jul 15, 2024

coderabbitai bot left a comment

feat: module hash by height query #20779

feat: module hash by height query #20779

Conversation

czarcas7ic commented Jun 25, 2024 • edited by coderabbitai bot Loading

Description

Author Checklist

Reviewers Checklist

Summary by CodeRabbit

coderabbitai bot commented Jun 25, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

facundomedica commented Jun 26, 2024

facundomedica Jun 26, 2024

Choose a reason for hiding this comment

czarcas7ic Jun 26, 2024

Choose a reason for hiding this comment

facundomedica Jun 26, 2024

Choose a reason for hiding this comment

czarcas7ic Jun 26, 2024

Choose a reason for hiding this comment

czarcas7ic Jun 26, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

czarcas7ic commented Jun 26, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

czarcas7ic commented Jul 15, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

czarcas7ic commented Jun 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 25, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)