feat(x/gov): emit proposer address in submit proposal event

[akaladarshi]

Description

Closes: #19831

Emit proposer address with submit_proposal event.

• Key: proposal_proposer
• Value: proposer address

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

• New Features
  • Enhanced proposal submission by including the proposer's information in event emissions. This allows for better tracking and visibility of proposal initiators.

[coderabbitai]

Walkthrough

Walkthrough

This update introduces the ability to emit the proposer's information in the submit_proposal event within the blockchain's governance module. It enhances event tracking and data retrieval capabilities by including the proposer's account address in event emissions, making it easier for users and applications to identify and interact with proposal transactions and blocks based on the proposer's identity.

Changes

Files	Change Summary
x/gov/keeper/proposal.go	Added AttributeKeyProposalProposer in SubmitProposal function for event emission.
x/gov/types/events.go	Included AttributeKeyProposalProposer to store proposer's account address in event types.

Assessment against linked issues

Objective	Addressed	Explanation
Emit proposer in submit_proposal event (#19831)	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yml

Commits

Files that changed from the base of the PR and between ac61b69 and 0ec66a1.

Files selected for processing (2)

• x/gov/keeper/proposal.go (1 hunks)
• x/gov/types/events.go (1 hunks)

Additional comments: 2

x/gov/types/events.go (1)

• 20-20: The addition of AttributeKeyProposalProposer is consistent with the existing structure and naming conventions of event attribute keys. This change effectively addresses the PR's objective to include the proposer's address in the submit_proposal event.

x/gov/keeper/proposal.go (1)

• 150-150: The addition of types.AttributeKeyProposalProposer to include the proposer's address in the event attributes is correctly implemented and logically placed within the SubmitProposal function. Ensure that the proposer variable is validated earlier in the function to prevent issues with invalid addresses.

[julienrbrt]

Thank you!

Normally we would need a changelog, but I'll add it in the backport.