fix: emit ante events even for the failed txs #10631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yun-yeo
force-pushed
the
feature/emit-failed-tx-ante-events
branch
from
c7125ad
to
4e04904
Compare
amaury1093
reviewed
Nov 29, 2021
alexanderbez
suggested changes
Nov 29, 2021
I'm not sure, master still have this problem. but v0.44.x should have this update for rosetta support |
alexanderbez
approved these changes
Nov 29, 2021
amaury1093
changed the title
|
This change is consensus-breaking because of the tx result change right? |
13 tasks
|
I don't think emitting new events is considered as consensus-breaking |
|
correct events are not included in hashes in the header |
4 tasks
zakir-code
pushed a commit
to PundiAI/cosmos-sdk
that referenced
this pull request
Apr 14, 2022
* emit ante events even for the failed txs * apply comment * add changelog
Eengineer1
pushed a commit
to cheqd/cosmos-sdk
that referenced
this pull request
Aug 26, 2022
* emit ante events even for the failed txs * apply comment * add changelog
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
* emit ante events even for the failed txs * apply comment * add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #10618
This is example implementation to emit ante events(especially of tx fee deduction) for the failed txs.
The master branch has huge difference in ante handler side (changed to middleware), so I just made changes only for v0.44.x branch.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change