Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return ResponseCheckTxWithEvents when running tx is failed #479

Closed
4 tasks
dudong2 opened this issue Mar 28, 2022 · 0 comments
Closed
4 tasks

return ResponseCheckTxWithEvents when running tx is failed #479

dudong2 opened this issue Mar 28, 2022 · 0 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/minor

Comments

@dudong2
Copy link
Contributor

dudong2 commented Mar 28, 2022

Summary

In this pr(cosmos/cosmos-sdk#10631), it is modified to emit ante even for the failed txs.
Unlike cosmos-sdk, ante events are not known because runTx is not called inside the CheckTxSync function.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@dudong2 dudong2 mentioned this issue Mar 29, 2022
Merged
5 tasks
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zemyblue @dudong2