Skip to content

ThanosEngine: Only enable default optimizers #6776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025
Merged

ThanosEngine: Only enable default optimizers #6776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## master / unreleased
* [BUGFIX] ThanosEngine: Only enable default optimizers. #6776
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to sort changelog items using predefined order mentioned in https://github.com/cortexproject/cortex/blob/master/RELEASE.md#prepare-your-release.

Since there are other items that are not ordered, we can skip for now and fix it at release time

* [ENHANCEMENT] Distributor: Add min/max schema validation for NativeHistograms. #6766
* [ENHANCEMENT] Ingester: Handle runtime errors in query path #6769
* [CHANGE] Ingester: Remove EnableNativeHistograms config flag and instead gate keep through new per-tenant limit at ingestion. #6718
Expand Down
2 changes: 1 addition & 1 deletion pkg/querier/engine_factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func NewEngineFactory(opts promql.EngineOpts, enableThanosEngine bool, reg prome
if enableThanosEngine {
thanosEngine = engine.New(engine.Opts{
EngineOpts: opts,
LogicalOptimizers: logicalplan.AllOptimizers,
LogicalOptimizers: logicalplan.DefaultOptimizers,
EnableAnalysis: true,
})
}
Expand Down
Loading