ThanosEngine: Only enable default optimizers #6776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
reviewed
May 31, 2025
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
config_optimizers
branch
from
9209e16 to
cd7ac6f
Compare
yeya24
approved these changes
Jun 1, 2025
| # Changelog | ||
|
|
||
| ## master / unreleased | ||
| * [BUGFIX] ThanosEngine: Only enable default optimizers. #6776 |
There was a problem hiding this comment.
We need to sort changelog items using predefined order mentioned in https://github.com/cortexproject/cortex/blob/master/RELEASE.md#prepare-your-release.
Since there are other items that are not ordered, we can skip for now and fix it at release time
justinjung04
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Let's only enable the default optimizers in Thanos engine. PropagateMatchersOptimizer seems to have bugs.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]