Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show events by default #8

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Do not show events by default #8

merged 2 commits into from
Feb 19, 2019

Conversation

corneliusweig
Copy link
Owner

This PR introduces a new flag --exclude which defaults to events, so that no events are shown any longer. It accepts resource names (only plural form) or shortnames. For example componentstatuses or cm (configMap).
The setting can also be configured in the ketall config file.

Closes #4

Cornelius Weig added 2 commits February 19, 2019 23:29
The flag excludes "events" resources by default, because this is rarely useful and clutters the output.
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@f76d17e). Click here to learn what that means.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   26.88%           
=========================================
  Files             ?        5           
  Lines             ?      186           
  Branches          ?        0           
=========================================
  Hits              ?       50           
  Misses            ?      134           
  Partials          ?        2
Impacted Files Coverage Δ
pkg/options/options.go 23.52% <ø> (ø)
pkg/client/client.go 28.72% <68.75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76d17e...529e9f2. Read the comment docs.

@corneliusweig corneliusweig merged commit 70a84ab into master Feb 19, 2019
@corneliusweig corneliusweig deleted the exclude-events branch February 19, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants