Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maybe exclude event.events.k8s.io by default? #4

Closed
ahmetb opened this issue Feb 18, 2019 · 3 comments
Closed

maybe exclude event.events.k8s.io by default? #4

ahmetb opened this issue Feb 18, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ahmetb
Copy link

ahmetb commented Feb 18, 2019

I can hardly think anyone would actually want to get all events (and similar status objects). The output is much more useful when I run get-all | grep -v ^event.

Maybe exclude events/* and event.events.k8s.io/* by default and offer an --include-events flag?

@corneliusweig corneliusweig self-assigned this Feb 19, 2019
@corneliusweig
Copy link
Owner

That does make sense. However, I'm thinking about a slightly more general approach: instead of providing a dedicated flag for this, there could be an --exclude flag for resources that should not be considered. If it defaults to events, the result will be the same.

@corneliusweig corneliusweig added the enhancement New feature or request label Feb 19, 2019
@ahmetb
Copy link
Author

ahmetb commented Feb 19, 2019

Yeah that sounds pretty cool. For some reasons I get two kinds of event objects in my output, I dunno why.

@corneliusweig
Copy link
Owner

Yes, me too. Those events differ by their api group. Same goes for deployments. I get some with deployment.apps and deployment.extensions. My assumption is that this has to do with old and new apiVersions coexisting (and probably the one is internally mapped to the other).
I wouldn't want to hide that away though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants