modules/ignition,platforms/*: Optionally allow users to set NTP servers for the cluster

[trawler]

NTP servers on Container Linux default to CoreOS time servers,
which may not be accessible on private cluster deployments.
Allow users to set a list of primary NTP servers with the CoreOS
servers as the default fallback.

This is rebased onto track-1 branch from @lander2k2 PR: #2652

[coreosbot]

Can one of the admins verify this patch?

[trawler]

ok to test

[trawler]

test this please

[trawler]

ok to test

[trawler]

ok to test

[cpanato]

retest this please

[cpanato]

following this PR to react in test failures

[cpanato]

retest this please, AZURE/GOVCLOUD

[cpanato]

retest this please. aws/metal. azure and gov are green

count has been removed from template definition, therefore the fix is no longer necessary

[alexsomesan]

Look ok.

[carlosaya]

has this been tested with vmware at all? I cannot terraform init. Get the following:

[root@ta030621-dev ite13]# ../../tectonic-installer/linux/terraform init ../../platforms/vmware
Downloading modules...
Error getting plugins: module root:
    5 error(s) occurred:

* module 'masters': unknown variable referenced: 'tectonic_ntp_servers'. define it with 'variable' blocks
* module 'ignition_masters': unknown variable referenced: 'tectonic_ntp_servers'. define it with 'variable' blocks
* module 'ignition_workers': unknown variable referenced: 'tectonic_ntp_servers'. define it with 'variable' blocks
* module 'workers': unknown variable referenced: 'tectonic_ntp_servers'. define it with 'variable' blocks
* module 'etcd': unknown variable referenced: 'tectonic_ntp_servers'. define it with 'variable' blocks
    module masters: ign_ntp_dropin_id is not a valid parameter
    module workers: ign_ntp_dropin_id is not a valid parameter
  module workers.root: 1 error(s) occurred:

* resource 'data.ignition_config.node' config: unknown variable referenced: 'ign_ntp_dropin_id'. define it with 'variable' blocksmodule masters.root: 1 error(s) occurred:

* resource 'data.ignition_config.node' config: unknown variable referenced: 'ign_ntp_dropin_id'. define it with 'variable' blocks

[coresolve]

@kalmog can you address the vmware question above?

[trawler]

It was indeed tested. Are you sure you have a clean branch?

karena@Karens-MacBook-Pro:~/go/src/github.com/coreos/tectonic-installer/build/kalmog (track-1) [ 10139283 ] $ terraform init ../../platforms/vmware
Initializing modules...
- module.etcd
- module.ignition_masters
- module.masters
- module.ignition_workers
- module.workers
- module.kube_certs
- module.etcd_certs
- module.ingress_certs
- module.identity_certs
- module.bootkube
- module.tectonic
- module.flannel_vxlan
- module.calico
- module.canal

Initializing provider plugins...

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see
any changes that are required for your infrastructure. All Terraform commands
should now work.

rerun this command to reinitialize your working directory. If you forget, other

[trawler]

@carlosaya Also, seems that you're using an older version of terraform. Please make sure your TF binary is version v0.11.1 and try again.