This repository was archived by the owner on Feb 5, 2020. It is now read-only.
modules/ignition,platforms/*: Optionally allow users to set NTP servers for the cluster #2652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
trawler
suggested changes
Jan 10, 2018
Contributor
trawler
left a comment
trawler
left a comment
There was a problem hiding this comment.
This commit seems to have only been applied for the openstack platform. if we want this to work for VmWare / other platforms, they should be added as well.
Contributor
Author
|
@kalmog So it was. I saw the examples (for all platforms) and didn't look deeper. I'll add a commit for the rest of the platforms... |
lander2k2
force-pushed
the
track-1_configurable-ntp
branch
from
d089b81 to
a0e90d6
Compare
NTP servers on Container Linux default to CoreOS time servers, which may not be accessible on private cluster deployments. Allow users to set a list of primary NTP servers with the CoreOS servers as the default fallback.
lander2k2
force-pushed
the
track-1_configurable-ntp
branch
from
eb33bd4 to
a118c36
Compare
Contributor
|
rebased at #2747 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NTP servers on Container Linux default to CoreOS time servers,
which may not be accessible on private cluster deployments.
Allow users to set a list of primary NTP servers with the CoreOS
servers as the default fallback.
This is cherry-picked onto track-1 branch from @lblackstone PR: #2213