This repository was archived by the owner on Feb 5, 2020. It is now read-only.
Bump Terraform to 0.10.7 #2041
Merged
Bump Terraform to 0.10.7 #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsomesan
requested review from
cpanato,
mxinden,
s-urbaniak,
squat and
trawler
mxinden
approved these changes
Oct 4, 2017
Contributor
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Great. Thanks for the changes!
mxinden
added a commit
to mxinden/tectonic-installer
that referenced
this pull request
Oct 5, 2017
The tectonic builder does not default to the CoreOS terraform version anymore since coreos#2041. This updates the documentation of the parameter.
cpanato
pushed a commit
that referenced
this pull request
Oct 5, 2017
The tectonic builder does not default to the CoreOS terraform version anymore since #2041. This updates the documentation of the parameter.
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jul 9, 2018
These were added in 15394f8 (tests: Add upstream terraform trigger, 2017-07-21, coreos/tectonic-installer#1444), but we returned to upstream Terraform in all cases in 379fd19 (Bump Terraform to 0.10.7, 2017-10-04, coreos/tectonic-installer#2041). Remove the stale docs.
yifan-gu
pushed a commit
to yifan-gu/installer
that referenced
this pull request
Jul 25, 2018
These were added in 15394f8 (tests: Add upstream terraform trigger, 2017-07-21, coreos/tectonic-installer#1444), but we returned to upstream Terraform in all cases in 379fd19 (Bump Terraform to 0.10.7, 2017-10-04, coreos/tectonic-installer#2041). Remove the stale docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this bump I've also flipped the TF download location back to the official upstream release.
We used to maintain a CoreOS fork with specific tweaks for overriding some tight timeouts to help our smoke tests. Those changes were actually isolated to the AWS provider which got split out into it's own repo. Also, with the recent improvements to the test framework we're not being blocked by those particular flakes anymore.
/cc: @sym3tri