tests: Use --bootable when generating derived commits#3971
Merged
cgwalters merged 1 commit intocoreos:mainfrom Aug 26, 2022
Merged
tests: Use --bootable when generating derived commits#3971cgwalters merged 1 commit intocoreos:mainfrom
--bootable when generating derived commits#3971cgwalters merged 1 commit intocoreos:mainfrom
Conversation
To ensure we consistently have the `ostree.bootable` key which we'd like to make mandatory in the future. cc ostreedev/ostree-rs-ext@9c4a75b
jlebon
approved these changes
Aug 26, 2022
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
Hmm, in the cases where we do --tree=ref=..., should we have libostree automatically pass through the bootable key if it's also set in the base ref? That would make it not required in most of these instances.
Member
Author
Yeah, it is tempting to do that by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure we consistently have the
ostree.bootablekey whichwe'd like to make mandatory in the future.
cc ostreedev/ostree-rs-ext@9c4a75b