Skip to content

build-fast: Also propagate ostree.bootable#3050

Merged
cgwalters merged 1 commit intocoreos:mainfrom
cgwalters:build-fast-keep-bootable
Aug 29, 2022
Merged

build-fast: Also propagate ostree.bootable#3050
cgwalters merged 1 commit intocoreos:mainfrom
cgwalters:build-fast-keep-bootable

Conversation

@cgwalters
Copy link
Member

To work with ostreedev/ostree-rs-ext@9c4a75b
which wants ostree-ext to hard require the key on container
images.

To work with ostreedev/ostree-rs-ext@9c4a75b
which wants ostree-ext to hard require the key on container
images.
--owner-uid 0 --owner-gid 0 --selinux-policy-from-base --link-checkout-speedup --no-bindings --no-xattrs \
--add-metadata-string=version="${version}" --parent="${previous_commit}" --keep-metadata='coreos-assembler.basearch' \
--keep-metadata='fedora-coreos.stream' --fsync=0 "${commit_args[@]}"; then
--keep-metadata='fedora-coreos.stream' --keep-metadata='ostree.bootable' --fsync=0 "${commit_args[@]}"; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as coreos/rpm-ostree#3971 (review), but for --base where it seems even more appropriate. :)

@cgwalters cgwalters merged commit 34c2ce5 into coreos:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants