Skip to content

app/compose: Fix help string for --ex-lockfile-strict#2064

Merged
openshift-merge-robot merged 1 commit intocoreos:masterfrom
jlebon:pr/lockfile-strict-help
Apr 20, 2020
Merged

app/compose: Fix help string for --ex-lockfile-strict#2064
openshift-merge-robot merged 1 commit intocoreos:masterfrom
jlebon:pr/lockfile-strict-help

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Apr 20, 2020

Minor follow-up to #1858. Make the help string here more helpful and
accurate.

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Apr 20, 2020

Aww, and I realize now that I didn't update the commit message in #1858 when I changed it as in #1858 (comment). Notably item (2) is no longer true.

Anyway, gonna clarify this in the PR top comment for posterity.

Minor follow-up to coreos#1858. Make the help string here more helpful and
accurate.
@jlebon jlebon force-pushed the pr/lockfile-strict-help branch from 7688474 to e7d365b Compare April 20, 2020 18:07
@dustymabe
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Copy Markdown
Member

Thanks for the help on this Dusty!

@openshift-merge-robot openshift-merge-robot merged commit 682aad2 into coreos:master Apr 20, 2020
@jlebon jlebon deleted the pr/lockfile-strict-help branch April 23, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants