Skip to content

pipeline: use cosa build --strict#226

Merged
jlebon merged 1 commit intocoreos:masterfrom
jlebon:pr/strict
Apr 20, 2020
Merged

pipeline: use cosa build --strict#226
jlebon merged 1 commit intocoreos:masterfrom
jlebon:pr/strict

Conversation

@jlebon
Copy link
Copy Markdown
Member

@jlebon jlebon commented Apr 20, 2020

We always want to build in strict mode. See:
coreos/fedora-coreos-tracker#454

We always want to build in strict mode. See:
coreos/fedora-coreos-tracker#454
@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Apr 20, 2020

Requires: coreos/coreos-assembler#1370

Copy link
Copy Markdown
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dustymabe
Copy link
Copy Markdown
Member

what happens when you pass --strict but don't have any lockfiles? i.e. if we try to run bodhi-updates through the pipeline again

@jlebon
Copy link
Copy Markdown
Member Author

jlebon commented Apr 20, 2020

what happens when you pass --strict but don't have any lockfiles? i.e. if we try to run bodhi-updates through the pipeline again

It has no effect if no lockfiles are passed. Relatedly, I've improved the help string for the switch in coreos/rpm-ostree#2064.

@jlebon jlebon merged commit 58fe322 into coreos:master Apr 20, 2020
@jlebon jlebon deleted the pr/strict branch April 20, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants