Skip to content

Conversation

@ajeddeloh
Copy link
Contributor

Depends on #772

Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we note some of the other minor changes that have happened (default file/dir permissions, removal of oem://, dropping of authorized_keys merging, command-line url flag, etc)?

@ajeddeloh
Copy link
Contributor Author

Typically we did spec change info in migrating configs doc, which I have yet to write (working on that next, along with 8000 other things to polish this)

NEWS Outdated
NOTE: In order to allow types from both the 2.x.y and 3.0.0 specs to be
vendored and imported in the same project, we are skipping version 1.0.0.
Go mod (and some other tools) treat v0.x and v1.x as the same when
importing packages with semantic import versioning)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

)

@ajeddeloh
Copy link
Contributor Author

Fixed extra close paren

Copy link
Contributor

@arithx arithx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Changes:

- Configs with version < 3.0.0 are now rejected
- Duplicate entries are now disallowed in lists
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be pointing out that it's only in some lists (i.e. you can have duplicates in appended contents). Not a deal breaker either way.

@ajeddeloh ajeddeloh merged commit 906cf04 into coreos:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants