fetch-offline: immediately return ErrNeedNet on OpenStack #1094
+14
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to (and revert of) coreos#1057. On OpenStack, we don't actually know if we're fetching from the config-drive or from the metadata server. In theory, if it's from the config-drive, we don't strictly need networking, and so `fetch-offline` would work. The issue is that in the more common case of the metadata server, `fetch-offline` will still wait the full 30s for the config-drive to also time out only to then have to bring up networking and run the `fetch` stage. Instead, let's just accept the brokenness of the OpenStack provider and declare it as always requiring networking. For more information, see: coreos#1081 (comment)
Member
Author
|
Still need to test this in OpenStack. |
cgwalters
approved these changes
Sep 16, 2020
Member
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
I'm OK with this but I still think we should explore in the future the idea of just bringing up the "primary interface" enough to do "link local networking". For example, I suspect we can just start sending out packets to 169.254.x.x without doing DHCP.
Member
Author
|
Tested working! |
bgilbert
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to (and revert of) #1057.
On OpenStack, we don't actually know if we're fetching from the
config-drive or from the metadata server.
In theory, if it's from the config-drive, we don't strictly need
networking, and so
fetch-offlinewould work. The issue is that in themore common case of the metadata server,
fetch-offlinewill still waitthe full 30s for the config-drive to also time out only to then have to
bring up networking and run the
fetchstage.Instead, let's just accept the brokenness of the OpenStack provider and
declare it as always requiring networking.
For more information, see:
#1081 (comment)