cloudstack|openstack: propagate ErrNeedNet #1057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On CloudStack/OpenStack, we fetch from three different sources simultaneously: two config drives, and the metadata service. Error-handling for these goroutines was causing `ErrNeedNet` from the latter to be ignored and so we weren't correctly propagating it back to the caller (which keys off of it to signal to the OS that networking is needed). Do a simple hack where we check if `ErrNeedNet` was hit and if none of the fetchers succeed, then we return that instead. (The better fix of course is to not try to parallel guess the metadata source like this, but that's a much bigger issue.) Fixes: coreos#956 Fixes: coreos#1056
Member
Author
|
Need to test this. |
lucab
reviewed
Jul 31, 2020
Member
Author
|
Tested working! (At least on an OpenStack with a metadata server; don't have access to one without, but I'm 95% confident it should work fine.) |
jlebon
added a commit
to jlebon/ignition
that referenced
this pull request
Sep 16, 2020
This is a follow up to (and revert of) coreos#1057. On OpenStack, we don't actually know if we're fetching from the config-drive or from the metadata server. In theory, if it's from the config-drive, we don't strictly need networking, and so `fetch-offline` would work. The issue is that in the more common case of the metadata server, `fetch-offline` will still wait the full 30s for the config-drive to also time out only to then have to bring up networking and run the `fetch` stage. Instead, let's just accept the brokenness of the OpenStack provider and declare it as always requiring networking. For more information, see: coreos#1081 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On CloudStack/OpenStack, we fetch from three different sources
simultaneously: two config drives, and the metadata service.
Error-handling for these goroutines was causing
ErrNeedNetfrom thelatter to be ignored and so we weren't correctly propagating it back to
the caller (which keys off of it to signal to the OS that networking is
needed).
Do a simple hack where we check if
ErrNeedNetwas hit and if none ofthe fetchers succeed, then we return that instead. (The better fix of
course is to not try to parallel guess the metadata source like this,
but that's a much bigger issue.)
Fixes: #956
Fixes: #1056