This repository was archived by the owner on Aug 25, 2021. It is now read-only.
02_ignition_firstboot: Enable networking if Ignition will run#57
Merged
dustymabe merged 1 commit intocoreos:masterfrom Mar 18, 2019
Merged
02_ignition_firstboot: Enable networking if Ignition will run#57dustymabe merged 1 commit intocoreos:masterfrom
dustymabe merged 1 commit intocoreos:masterfrom
Conversation
Today coreos-assembler is hardcoding the initramfs networking kargs to do DHCP; this is problematic for e.g. bare metal where one often wants to configure static networking. Let's only enable initramfs networking if we're doing Ignition.
bgilbert
approved these changes
Mar 18, 2019
Contributor
bgilbert
left a comment
bgilbert
left a comment
There was a problem hiding this comment.
LGTM as an interim improvement. Eventually the initramfs itself should be enabling networking as needed.
dustymabe
approved these changes
Mar 18, 2019
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Mar 27, 2019
With this I'll have to find a way to remove my "eth0 FOR LIFE" tattoo. This came up in a bigger discussion with OpenStack: coreos/ignition#769 (comment) The history behind disabling persistent NIC naming in Fedora/RHEL is...long. I think we have an opportunity now to do a clean break with that history. Let's use persistent NIC naming even for cloud environments like AWS. This massively reduces the delta between our "metal" and "openstack" images. We just have console tweaks and `no_timer_check`. Note that with coreos/ignition-dracut#57 we actually do do DHCP on all interfaces anyways, so the hardcoded `eth0` here made even less sense.
cgwalters
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Mar 27, 2019
With this I'll have to find a way to remove my "eth0 FOR LIFE" tattoo. This came up in a bigger discussion with OpenStack: coreos/ignition#769 (comment) The history behind disabling persistent NIC naming in Fedora/RHEL is...long. I think we have an opportunity now to do a clean break with that history. Let's use persistent NIC naming even for cloud environments like AWS. This massively reduces the delta between our "metal" and "openstack" images. We just have console tweaks and `no_timer_check`. Note that with coreos/ignition-dracut#57 we actually do do DHCP on all interfaces anyways, so the hardcoded `eth0` here made even less sense.
ashcrow
pushed a commit
to ashcrow/coreos-assembler
that referenced
this pull request
May 30, 2019
With this I'll have to find a way to remove my "eth0 FOR LIFE" tattoo. This came up in a bigger discussion with OpenStack: coreos/ignition#769 (comment) The history behind disabling persistent NIC naming in Fedora/RHEL is...long. I think we have an opportunity now to do a clean break with that history. Let's use persistent NIC naming even for cloud environments like AWS. This massively reduces the delta between our "metal" and "openstack" images. We just have console tweaks and `no_timer_check`. Note that with coreos/ignition-dracut#57 we actually do do DHCP on all interfaces anyways, so the hardcoded `eth0` here made even less sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today coreos-assembler is hardcoding the initramfs networking kargs to
do DHCP; this is problematic for e.g. bare metal where one often wants
to configure static networking.
Let's only enable initramfs networking if we're doing Ignition.