image-cloud: Use persistent NIC naming, drop eth0 #442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this I'll have to find a way to remove my "eth0 FOR LIFE" tattoo. This came up in a bigger discussion with OpenStack: coreos/ignition#769 (comment) The history behind disabling persistent NIC naming in Fedora/RHEL is...long. I think we have an opportunity now to do a clean break with that history. Let's use persistent NIC naming even for cloud environments like AWS. This massively reduces the delta between our "metal" and "openstack" images. We just have console tweaks and `no_timer_check`. Note that with coreos/ignition-dracut#57 we actually do do DHCP on all interfaces anyways, so the hardcoded `eth0` here made even less sense.
cgwalters
changed the title
Member
Author
|
Marking WIP while I test this with RHCOS + OpenShift installer a bit more. But I did verify that we are doing DHCP on all interfaces with FCOS today. |
cgwalters
changed the title
Member
Author
|
Lifting WIP, this works for me just fine in AWS today with OpenShift 4. |
Contributor
|
LGTM 👍 |
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Apr 16, 2019
We regressed on [1] when moving towards persistent NIC naming in [2]. It's cleaner to have the config for this here anyway. This tells NetworkManager to default to using the MAC address as the client ID during DHCP requests to ensure we get the same IP address again during network setup in the real root. See [3] for more background on this. [1] coreos/fedora-coreos-tracker#156 [2] coreos/coreos-assembler#442 [3] coreos/coreos-assembler#367
cgwalters
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Apr 17, 2019
We regressed on [1] when moving towards persistent NIC naming in [2]. It's cleaner to have the config for this here anyway. This tells NetworkManager to default to using the MAC address as the client ID during DHCP requests to ensure we get the same IP address again during network setup in the real root. See [3] for more background on this. [1] coreos/fedora-coreos-tracker#156 [2] coreos/coreos-assembler#442 [3] coreos/coreos-assembler#367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this I'll have to find a way to remove my "eth0 FOR LIFE" tattoo.
This came up in a bigger discussion with OpenStack:
coreos/ignition#769 (comment)
The history behind disabling persistent NIC naming in Fedora/RHEL
is...long.
I think we have an opportunity now to do a clean break with that
history. Let's use persistent NIC naming even for cloud environments
like AWS.
This massively reduces the delta between our "metal" and "openstack"
images. We just have console tweaks and
no_timer_check.Note that with coreos/ignition-dracut#57
we actually do do DHCP on all interfaces anyways, so the hardcoded
eth0here made even less sense.