ignition-ostree: Split unit for sysroot mounting#210
Merged
jlebon merged 1 commit intocoreos:testing-develfrom Oct 31, 2019
Merged
ignition-ostree: Split unit for sysroot mounting#210jlebon merged 1 commit intocoreos:testing-develfrom
jlebon merged 1 commit intocoreos:testing-develfrom
Conversation
cgwalters
force-pushed
the
sysroot-always-mount
branch
from
7e11e0c to
c0adff1
Compare
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Oct 31, 2019
…efault"" This reverts commit e92be85. It will work now with coreos/fedora-coreos-config#210
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Oct 31, 2019
This reverts commit e92be85. It will work now with coreos/fedora-coreos-config#210
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Oct 31, 2019
This reverts commit e92be85. It will work now with coreos/fedora-coreos-config#210
miabbott
reviewed
Oct 31, 2019
| ConditionKernelCommandLine=ostree | ||
| ConditionPathExists=!/run/ostree-live | ||
|
|
||
| # There can be only one, Highlander style |
jlebon
reviewed
Oct 31, 2019
.../usr/lib/dracut/modules.d/40ignition-ostree/ignition-ostree-mount-subsequent-sysroot.service
Show resolved
Hide resolved
.../05core/usr/lib/dracut/modules.d/40ignition-ostree/ignition-ostree-mount-ign-sysroot.service
Outdated
Show resolved
Hide resolved
| "/usr/sbin/ignition-ostree-populate-var" | ||
|
|
||
| install_ignition_unit ignition-ostree-mount-sysroot.service | ||
| install_ignition_unit ignition-ostree-mount-ign-sysroot.service |
Member
There was a problem hiding this comment.
Could also make the complete/subsequent thing another arg of install_ignition_unit, but definitely not a blocker!
overlay.d/05core/usr/lib/dracut/modules.d/40ignition-ostree/module-setup.sh
Outdated
Show resolved
Hide resolved
cgwalters
force-pushed
the
sysroot-always-mount
branch
from
c0adff1 to
add0180
Compare
The unit to mount sysroot only worked the *first* boot because it was integrated with Ignition. We need to have separate units with different dependencies (but that execute the same code) for the "Ignition boot" compared with "subsequent" boots. Depends coreos/ignition-dracut#131
cgwalters
force-pushed
the
sysroot-always-mount
branch
from
add0180 to
cb21036
Compare
jlebon
approved these changes
Oct 31, 2019
Member
jlebon
left a comment
jlebon
left a comment
There was a problem hiding this comment.
LGTM! Let's merge on green CI.
Member
|
Which speaking of... #214. |
Contributor
|
But... if sysroot mount-ing was coupled with firstboot/ignition, how current code still works with subsequent boots ? |
Contributor
|
Ah the current code works and it just doesn't distinguish between first and subsequent boots. |
Member
It's currently not active because we still specify the |
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Nov 1, 2019
This reverts commit e92be85. It will work now with coreos/fedora-coreos-config#210
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Nov 1, 2019
This reverts commit e92be85. It will work now with coreos/fedora-coreos-config#210
jlebon
pushed a commit
to coreos/coreos-assembler
that referenced
this pull request
Nov 1, 2019
This reverts commit e92be85. It will work now with coreos/fedora-coreos-config#210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unit to mount sysroot only worked the first boot
because it was integrated with Ignition. We need to have
separate units with different dependencies (but that execute
the same code) for the "Ignition boot" compared with "subsequent"
boots.
Depends coreos/ignition-dracut#131