(take2) create_disk: Drop the root= and rootflags= kargs by default#883
(take2) create_disk: Drop the root= and rootflags= kargs by default#883jlebon merged 1 commit intocoreos:masterfrom
Conversation
|
Depends coreos/fedora-coreos-config#210 Don't merge until til both FCOS and RHCOS have the Ignition and fcos-config changes please! |
darkmuggle
left a comment
darkmuggle
left a comment
There was a problem hiding this comment.
After the other PRs land, LGTM.
|
Actually this PR needs to land after we've done the manual integration for the |
|
Let's make sure CI is green before merging this now that #884 is in, so we have tests that should exercise reboots too. |
cgwalters
force-pushed
the
re-revert-drop-rootflag
branch
from
8bcd560 to
1d9df3a
Compare
|
OK, so now CI is correctly failing here because we don't have the new ignition-dracut in the lockfiles for testing-devel. I am trying to follow this commit but...ah, OK someone with magic permissions needs to tag it into the pool I think. Right? |
|
/cc @jlebon @dustymabe |
|
You can just open a PR to add the override. Once it's merged, the tagger will tag it in automatically. |
To help us merge coreos/coreos-assembler#883
To help us merge coreos/coreos-assembler#883
This reverts commit e92be85. It will work now with coreos/fedora-coreos-config#210
cgwalters
force-pushed
the
re-revert-drop-rootflag
branch
from
1d9df3a to
111cde2
Compare
|
Nice, all green! Just doing some final sanity-checking locally as well. |
|
OK, I'm hitting issues with Anyway, works fine otherwise! |
Taking a look at that now. |
|
I'm not reproducing an issue using this fcct for /var ? |
Sorry for the noise, it's related to the SELinux labeling work I'm hacking on in parallel. |
4 participants
This reverts commit e92be85.
It will work now with coreos/fedora-coreos-config#210