overlay.d: Split up preset file #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This renames without modifying, so pinger is enabled in both. Was that intended? |
cgwalters
force-pushed
the
rename-presets
branch
from
feadc3b to
c0d7ef5
Compare
Member
Author
|
Good catch, fixed! |
ajeddeloh
approved these changes
Aug 6, 2019
Contributor
ajeddeloh
left a comment
ajeddeloh
left a comment
There was a problem hiding this comment.
LGTM other than lets add a comment to each explaining what should go where so we don't add things to the wrong place in the future by accident.
Member
Author
|
Good idea, prep in coreos/coreos-assembler#691 |
RHCOS also has the name `42-coreos.preset` in a different place. Trying to avoid having them conflict, let's both work around the conflict and make things clearer by renaming/splitting the preset files. The FCOS-specific bit goes into `15fcos`.
cgwalters
force-pushed
the
rename-presets
branch
from
c0d7ef5 to
d6d7183
Compare
Member
Author
|
OK now with a |
Member
maybe in the future we could name the RHCOS version 42-rhcos.preset and put it in its own subdir so we prevent having another problem like this down the line. |
dustymabe
pushed a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 19, 2024
Tutorials imported from Dusty Mabe's Devconf.cz 2020 Fedora CoreOS Lab: https://dustymabe.com/2020/01/23/devconf.cz-2020-fedora-coreos-lab/ Fixes: coreos#106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHCOS also has the name
42-coreos.presetin a different place.Trying to avoid having them conflict, let's both work around
the conflict and make things clearer by renaming/splitting the
preset files.
The FCOS-specific bit goes into
15fcos.