DNM: overlay/systemd/boot-efi.mount: use efivars#106
Closed
ajeddeloh wants to merge 1 commit intocoreos:testing-develfrom
Closed
DNM: overlay/systemd/boot-efi.mount: use efivars#106ajeddeloh wants to merge 1 commit intocoreos:testing-develfrom
ajeddeloh wants to merge 1 commit intocoreos:testing-develfrom
Conversation
Only mount /boot/efi if we're running on EFI
Member
|
(Rather than DNM you can now on GH mark PRs as drafts btw) Anyways LGTM! |
Contributor
Author
|
Thinking about this more, once coreos/coreos-assembler#563 merges there shouldn't be any reason to mount the ESP at all. How do you feel about just not mounting it ever? |
Member
|
This will be obsoleted by #155 |
dustymabe
pushed a commit
to jbtrystram/fedora-coreos-config
that referenced
this pull request
Apr 19, 2024
Tutorials imported from Dusty Mabe's Devconf.cz 2020 Fedora CoreOS Lab: https://dustymabe.com/2020/01/23/devconf.cz-2020-fedora-coreos-lab/ Fixes: coreos#106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only mount /boot/efi if we're running on EFI
see discussion here:
#105 (review)
Marking DNM since we don't have consensus on it yet