Skip to content

Add scripts to verify BZ1980679#1230

Closed
HuijingHei wants to merge 9 commits intocoreos:testing-develfrom
HuijingHei:hhei-dev
Closed

Add scripts to verify BZ1980679#1230
HuijingHei wants to merge 9 commits intocoreos:testing-develfrom
HuijingHei:hhei-dev

Conversation

@HuijingHei
Copy link
Copy Markdown
Member

@HuijingHei HuijingHei commented Sep 22, 2021

This PR is to add scripts to verify https://bugzilla.redhat.com/show_bug.cgi?id=1980679:

  1. config.ign to include remote.ign
  2. Verify kernel arg and exists /etc/testfile

The remote ignition file will be used to verify BZ1980679, including
inject kernel arguments and write something to /etc/testfile
config.ign to include remote.ign
verify kernel arg and exists /etc/testfile
@dustymabe
Copy link
Copy Markdown
Member

this shouldn't be passing CI because https://raw.githubusercontent.com/coreos/fedora-coreos-config/testing-devel/tests/kola/ignition/remote/remote.ign doesn't exist yet (won't exist until #1227) is merged.

What I notice from the CI run is that the test isn't running, hence why CI is passing. I suspect there is something wrong with this line:

# kola: { "platforms": "! qemu-unpriv", "tags": "needs-internet" }

@saqibali-2k
Copy link
Copy Markdown
Contributor

saqibali-2k commented Sep 22, 2021

this shouldn't be passing CI because https://raw.githubusercontent.com/coreos/fedora-coreos-config/testing-devel/tests/kola/ignition/remote/remote.ign doesn't exist yet (won't exist until #1227) is merged.

What I notice from the CI run is that the test isn't running, hence why CI is passing. I suspect there is something wrong with this line:

# kola: { "platforms": "! qemu-unpriv", "tags": "needs-internet" }

The "platforms": "! qemu-unpriv" puts an exclusion on qemu, is that what is messing with CI? Adding the same tag locally and running on aws with ./cosa kola run -p=aws --aws-credentials-file=./aws_credentials seems to run the test.

@dustymabe
Copy link
Copy Markdown
Member

obvious question incoming: is there good reason to not test this on qemu?

@saqibali-2k
Copy link
Copy Markdown
Contributor

obvious question incoming: is there good reason to not test this on qemu?

Hmm not sure, I think Huijing left a comment in the previous PR. Quoting: qemu-unpriv machines cannot communicate to network. I think she will probably expand it on tomorrow.

@HuijingHei HuijingHei closed this Sep 23, 2021
@HuijingHei HuijingHei deleted the hhei-dev branch September 23, 2021 03:27
@HuijingHei
Copy link
Copy Markdown
Member Author

Thanks @dustymabe and @saqibali-2k
My branch has something uncontrolled, so I del this and create another PR #1231

@HuijingHei
Copy link
Copy Markdown
Member Author

Duplicate of #1232

@HuijingHei HuijingHei marked this as a duplicate of #1232 Sep 24, 2021
@HuijingHei HuijingHei added the duplicate This issue or pull request already exists label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants