-
Notifications
You must be signed in to change notification settings - Fork 171
Add remote ignition file which will be used to verify BZ1980679 #1227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please expand your commit messages to have more rationale/context. See the contributing guide on |
Sure, thanks @miabbott |
saqibali-2k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving this Huijing!
dustymabe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only thing I would change is to split the commit message to multiple lines (line break at 70 or 80 characters)
The remote ignition file will be used to verify BZ1980679, including
inject kernel arguments and write something to /etc/testfile.
The remote ignition file will be used to verify BZ1980679, including inject kernel arguments and write something to /etc/testfile
Thanks @dustymabe. Oh, sorry, I missed your commit |
travier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for the second PR to be up and ready to merge this one
Do we need to merge this PR before she can post the second one? |
|
I am a little confused about the PR, seems all the files are in #1230 now, then ignore this PR? thanks! |
This PR needs to merge first so the remote file will exist in GitHub. See #1230 (comment) |
This PR is just the remote.ign file should be put on the github, which will be included in config.ign
Test to verify https://bugzilla.redhat.com/show_bug.cgi?id=1980679, steps: