Skip to content

Conversation

@HuijingHei
Copy link
Member

@HuijingHei HuijingHei commented Sep 22, 2021

This PR is just the remote.ign file should be put on the github, which will be included in config.ign

Test to verify https://bugzilla.redhat.com/show_bug.cgi?id=1980679, steps:

  1. remote.ign on github: inject kernel arguments and write something to /etc/testfile
  2. config.ign to include remote kargsfile.ign
  3. Verify kernel arg and exists /etc/testfile

@miabbott
Copy link
Member

Please expand your commit messages to have more rationale/context. See the contributing guide on ostreedev/ostree for suggestions on how to format commit messages - https://github.com/ostreedev/ostree/blob/main/docs/CONTRIBUTING.md#commit-message-style

@HuijingHei
Copy link
Member Author

Please expand your commit messages to have more rationale/context. See the contributing guide on ostreedev/ostree for suggestions on how to format commit messages - https://github.com/ostreedev/ostree/blob/main/docs/CONTRIBUTING.md#commit-message-style

Sure, thanks @miabbott

@HuijingHei HuijingHei changed the title Add auto script to verify remote ignition refer to BZ1980679 Add remote ignition file which will be used to verify BZ1980679 Sep 22, 2021
Copy link
Contributor

@saqibali-2k saqibali-2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this Huijing!

dustymabe
dustymabe previously approved these changes Sep 22, 2021
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only thing I would change is to split the commit message to multiple lines (line break at 70 or 80 characters)

The remote ignition file will be used to verify BZ1980679, including
inject kernel arguments and write something to /etc/testfile.

The remote ignition file will be used to verify BZ1980679, including
inject kernel arguments and write something to /etc/testfile
@HuijingHei
Copy link
Member Author

LGTM

Only thing I would change is to split the commit message to multiple lines (line break at 70 or 80 characters)

The remote ignition file will be used to verify BZ1980679, including
inject kernel arguments and write something to /etc/testfile.

Thanks @dustymabe. Oh, sorry, I missed your commit

@HuijingHei HuijingHei enabled auto-merge (rebase) September 22, 2021 15:13
@HuijingHei HuijingHei disabled auto-merge September 22, 2021 15:13
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for the second PR to be up and ready to merge this one

@dustymabe
Copy link
Member

LGTM, waiting for the second PR to be up and ready to merge this one

Do we need to merge this PR before she can post the second one?

@HuijingHei HuijingHei enabled auto-merge (rebase) September 22, 2021 16:14
@HuijingHei HuijingHei disabled auto-merge September 22, 2021 16:15
@HuijingHei
Copy link
Member Author

I am a little confused about the PR, seems all the files are in #1230 now, then ignore this PR? thanks!

@dustymabe
Copy link
Member

I am a little confused about the PR, seems all the files are in #1230 now, then ignore this PR? thanks!

This PR needs to merge first so the remote file will exist in GitHub. See #1230 (comment)

@HuijingHei HuijingHei merged commit 7d524f1 into coreos:testing-devel Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants