cmdlib: Drop unsafety for cache disk#3619
Merged
dustymabe merged 1 commit intocoreos:mainfrom Sep 14, 2023
Merged
Conversation
This can't really be safe here because we have to ensure that the stuff we write makes it to the filesystem image between a separated fetch + build process. cc coreos#3591 which I suspect this will fix, but didn't verify.
dustymabe
added a commit
to dustymabe/fedora-coreos-pipeline
that referenced
this pull request
Sep 16, 2023
Some recent changes like droping unsafety for the cache disk [1] and also adding a few more root reprovision tests that get run on the ppc64le platform [2] are causing us to bump up into the 2 hour time limit. Let's bump it. [1] coreos/coreos-assembler#3619 [2] coreos/fedora-coreos-config#2597
jlebon
pushed a commit
to coreos/fedora-coreos-pipeline
that referenced
this pull request
Sep 16, 2023
Some recent changes like droping unsafety for the cache disk [1] and also adding a few more root reprovision tests that get run on the ppc64le platform [2] are causing us to bump up into the 2 hour time limit. Let's bump it. [1] coreos/coreos-assembler#3619 [2] coreos/fedora-coreos-config#2597
Member
|
Seems like we're still hitting this: #3631 (comment) Wonder if we should revert this given that (we think) it has slowed down the pipeline. Is it truly unsafe to use unsafe in an orderly shutdown? |
Member
|
I do think |
Member
Author
Not sure we do that in an orderly way though reliably? Needs investigation.
I have no opposition to that.
Yeah, fair. |
aaradhak
pushed a commit
to aaradhak/fedora-coreos-pipeline
that referenced
this pull request
May 14, 2024
Some recent changes like droping unsafety for the cache disk [1] and also adding a few more root reprovision tests that get run on the ppc64le platform [2] are causing us to bump up into the 2 hour time limit. Let's bump it. [1] coreos/coreos-assembler#3619 [2] coreos/fedora-coreos-config#2597
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can't really be safe here because we have to ensure that the stuff we write makes it to the filesystem image between a separated fetch + build process.
cc #3591 which I suspect this will fix, but didn't verify.