cmdlib: Drop cache qcow2, just use virtiofs#3615
cmdlib: Drop cache qcow2, just use virtiofs#3615cgwalters wants to merge 1 commit intocoreos:mainfrom
Conversation
Another chunk of technical debt drops away; we went through a lot of gyrations in the initial development of doing rpm-ostree+qemu, but just using virtiofs to talk to the host seems to work fine here now. An immediate motivation is coreos/rpm-ostree#4565
dustymabe
left a comment
dustymabe
left a comment
There was a problem hiding this comment.
Haven't tested this myself but I certainly like the direction!
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| mv -T cache2.qcow2.tmp "${workdir}"/cache/cache2.qcow2 | ||
| fi | ||
| # And remove the old one | ||
| # Clean up old cache qcow2; we now always rely on virtiofs |
There was a problem hiding this comment.
Since CI failed and we'll need to do another run.. maybe we can add a comment here to say to delete the runvm_with_cache function after 2023 to let future us know for sure when it's safe to get rid of it.
There was a problem hiding this comment.
Or we can move the rm -vf to runvm() and nuke it now. There's only two callers of that function, defined just above it.
|
for: You might need change things to pass |
Hmm, strange...this works in my toolbox setup. I am a little uncertain about adding Will dig in at some point, for now moving to draft. (edit: And the probable short term fix is #3619 ) |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This comment was marked as spam.
This comment was marked as spam.
Now that our OSBuild workflow is using the cache we saw at least one case where the pipeline was running out of space. Since we had a previous proposal [1] to just drop the cahce altogether anyway let's try to at least remove it from the runcompose functions to eliminate the use of it there anyway. [1] coreos#3615
Now that our OSBuild workflow is using the cache we saw at least one case where the pipeline was running out of space when composing the extensions. Since we had a previous proposal [1] to just drop the cache altogether anyway let's try to at least remove it from the runcompose functions to eliminate the use of it there anyway. [1] coreos#3615
Now that our OSBuild workflow is using the cache we saw at least one case where the pipeline was running out of space when composing the extensions. Since we had a previous proposal [1] to just drop the cache altogether anyway let's try to at least remove it from the runcompose functions to eliminate the use of it there anyway. [1] coreos#3615
|
closing this old PR out. there is an evolution of it in #3720, which also stalled unfortunately. |
5 participants
Another chunk of technical debt drops away; we went through a lot of gyrations in the initial development of doing rpm-ostree+qemu, but just using virtiofs to talk to the host seems to work fine here now.
An immediate motivation is coreos/rpm-ostree#4565