build: Identify target disk by wwn #1343
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Regression from: coreos#1342 We'd die in pid 1 if the cache disk isn't found, which happens in the privileged case.
This is a followup to: coreos#1342 which is part of: coreos#1289 Our builds right now run qemu in a way that's highly sensitive to changes in device ordering. SCSI hardware supports a [world wide name](https://en.wikipedia.org/wiki/World_Wide_Name); change our qemu invocation to use `42` (in decimal) for that. Unfortunately because we're not using udev in our supermin VM right now we don't get the nice `/dev/disk/by-id` symlink to it. Instead just walk `/sys/block` manually.
Member
Author
|
@Prashanth684 mind testing this on !x86_64? |
Contributor
yes. will definitely try to get to this today. |
Member
Author
Thanks! And in addition it'd be good to test the final result in: |
Contributor
Member
Author
|
Splitting this out as a separate PR was good for clarity and to get independent testing, but I think we're good to ship #1289 fully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to:
#1342
which is part of:
#1289
Our builds right now run qemu in a way that's highly sensitive
to changes in device ordering.
SCSI hardware supports a world wide name;
change our qemu invocation to use
42(in decimal) for that.Unfortunately because we're not using udev in our supermin
VM right now we don't get the nice
/dev/disk/by-idsymlinkto it. Instead just walk
/sys/blockmanually.