Use an explicit cosa-cache label for cache2.qcow2
#1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to rework our build process to use `kola qemuexec` and complete the move all the core qemu logic into mantle. Today our build logic ends up hardcoding specific devices like `/dev/sdb1` which is extremely fragile. Let's use labels instead, and start with the cache device. Rename the cache to `cache2.qcow2` and remove the old one so we can reliably find the label.
ashcrow
approved these changes
Apr 13, 2020
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 13, 2020
This is a followup to: coreos#1342 which is part of: coreos#1289 Our builds right now run qemu in a way that's highly sensitive to changes in device ordering. SCSI hardware supports a [world wide name](https://en.wikipedia.org/wiki/World_Wide_Name); change our qemu invocation to use `42` (in decimal) for that. Unfortunately because we're not using udev in our supermin VM right now we don't get the nice `/dev/disk/by-id` symlink to it. Instead just walk `/sys/block` manually.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 13, 2020
This is a followup to: coreos#1342 which is part of: coreos#1289 Our builds right now run qemu in a way that's highly sensitive to changes in device ordering. SCSI hardware supports a [world wide name](https://en.wikipedia.org/wiki/World_Wide_Name); change our qemu invocation to use `42` (in decimal) for that. Unfortunately because we're not using udev in our supermin VM right now we don't get the nice `/dev/disk/by-id` symlink to it. Instead just walk `/sys/block` manually.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 13, 2020
Regression from: coreos#1342 We'd die in pid 1 if the cache disk isn't found, which happens in the privileged case.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 13, 2020
This is a followup to: coreos#1342 which is part of: coreos#1289 Our builds right now run qemu in a way that's highly sensitive to changes in device ordering. SCSI hardware supports a [world wide name](https://en.wikipedia.org/wiki/World_Wide_Name); change our qemu invocation to use `42` (in decimal) for that. Unfortunately because we're not using udev in our supermin VM right now we don't get the nice `/dev/disk/by-id` symlink to it. Instead just walk `/sys/block` manually.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Apr 14, 2020
Regression from: #1342 We'd die in pid 1 if the cache disk isn't found, which happens in the privileged case.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 22, 2020
And this final commit gets rid of almost all the core qemu logic in cmdlib, so e.g. architecture specific changes only need to happen in one place. The only special casing left is `$devtype` and the terminal. First, change how we identify devices. This is a followup to: coreos#1342 which is part of: coreos#1289 Our builds right now run qemu in a way that's highly sensitive to changes in device ordering. SCSI hardware supports a [world wide name](https://en.wikipedia.org/wiki/World_Wide_Name); change our qemu invocation to use `42` (in decimal) for that. Unfortunately because we're not using udev in our supermin VM right now we don't get the nice `/dev/disk/by-id` symlink to it. Instead just walk `/sys/block` manually. Next, use `kola qemuexec`. We inherit the virtio-rand setup, CPU calculations etc. And now we can just use virtio for the root disk and the cache disk, which drops all the eyeball-glazing scsi incantations. (Well, of course arch changes also end up in libvirt which we use indirectly too, but at least *we* only have one place)
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Apr 22, 2020
This is a followup to: coreos#1342 which is part of: coreos#1289 Our builds right now run qemu in a way that's highly sensitive to changes in device ordering. SCSI hardware supports a [world wide name](https://en.wikipedia.org/wiki/World_Wide_Name); change our qemu invocation to use `42` (in decimal) for that. Unfortunately because we're not using udev in our supermin VM right now we don't get the nice `/dev/disk/by-id` symlink to it. Instead just walk `/sys/block` manually.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Apr 22, 2020
This is a followup to: #1342 which is part of: #1289 Our builds right now run qemu in a way that's highly sensitive to changes in device ordering. SCSI hardware supports a [world wide name](https://en.wikipedia.org/wiki/World_Wide_Name); change our qemu invocation to use `42` (in decimal) for that. Unfortunately because we're not using udev in our supermin VM right now we don't get the nice `/dev/disk/by-id` symlink to it. Instead just walk `/sys/block` manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to rework our build process to use
kola qemuexecand complete the move all the core qemu logic into mantle.
Today our build logic ends up hardcoding specific devices like
/dev/sdb1which is extremely fragile. Let's use labels instead,and start with the cache device.
Rename the cache to
cache2.qcow2and remove the old one so wecan reliably find the label.